Refactor stats logic to use a common function.#749
Merged
tanabi merged 1 commit intofuzzball-muck:masterfrom May 20, 2025
Merged
Refactor stats logic to use a common function.#749tanabi merged 1 commit intofuzzball-muck:masterfrom
tanabi merged 1 commit intofuzzball-muck:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR collects the main logic from
STATS,STATS_ARRAY, and@statsinto a common functioncollect_dbstats.The builtin version of
@statsgave information on old, propchanged, and proploaded objects (an unlisted feature) - but even starterdb overrides this command.If there's a need to keep those, I can exempt
@statsfrom this refactor. I could see a future@debug diskbasesubcommand though (and@find =@=countseems to work for the other)