Handle keyring storage failures with actionable error#9
Open
sharoonthomas wants to merge 1 commit into
Open
Conversation
The system keyring can reject writes on macOS when an existing 'fulfil-cli' entry was created by a different binary (error -25244, errSecMissingEntitlement). Previously this surfaced as an unhandled traceback from the middle of 'fulfil auth login'. Catch PasswordSetError and KeyringLocked in the storage functions and re-raise as a new KeyringError with a platform-specific hint: - macOS: run 'security delete-generic-password -s fulfil-cli' - other: check that the keyring daemon is unlocked The login commands route the error through handle_error so the user gets a clean red message (or JSON when piped) with remediation instead of a traceback. Partial workspace state is not written on failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The system keyring can reject writes on macOS when an existing 'fulfil-cli' entry was created by a different binary (error -25244, errSecMissingEntitlement). Previously this surfaced as an unhandled traceback from the middle of 'fulfil auth login'.
Catch PasswordSetError and KeyringLocked in the storage functions and re-raise as a new KeyringError with a platform-specific hint:
The login commands route the error through handle_error so the user gets a clean red message (or JSON when piped) with remediation instead of a traceback. Partial workspace state is not written on failure.