#154672011 - feedback implementation by fuchodeveloper · Pull Request #86 · fuchodeveloper/more-recipes

fuchodeveloper · 2018-01-26T18:58:47Z

Description of Task to be completed?

Code review feedback implementation

How should this be manually tested?

Clone the project locally from git clone https://github.com/fuchodeveloper/more-recipes.git
Open the project in your terminal
Install all the necessary dependencies as stated in the README file
Run app locally using $ npm run start:dev
Navigate to homepage http://localhost:8000
Sign up or sign in
Navigate to add recipe page from the navigation bar
Go ahead to create recipes

Any background context you want to provide?

User is required to be authenticated in order to perform privileged actions such as creating recipes

What are the relevant pivotal tracker stories?

story type: chore
story id: 154672011
story title: Code review feedback implementation

Questions:

N/A

#152782762 review api endpoints and refactor where necessary - start implementing refactored API documentation

- code cleanup - add hound.yml file

…51251709 Cleanup

- refactore docs server host - check status codes - refactor function names to fit convention

(ch): server API review

implement code review feedback add faker for tests refactor up upvotes action refactor get all recipes and sort recipes route

(ch): refactor tests

Ch implement more feedback

- follow conventions in app setup test config for local and remote test global loader type for components

refactor client view recipe

feedback and initial frontend implementation

Finishes #151251426

…t-app-pagination #151251426 - User should be able to navigate the app using pagination

…-favorited-recipes #151246935 - User should be able to retrieve favorited recipes

…onventions and best practices Finishes #154322898

…tices

…pp-conventions #154322898 - refactor app conventions

- create production configuration for webpack - update app entry file to use production configuration - files refactoring

- add higher order component to catch errors - refactor files Finishes #154422313

houndci-bot · 2018-01-26T18:59:40Z

@@ -0,0 +1,27 @@
+import isEmpty from 'lodash/isEmpty';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:40Z

@@ -0,0 +1,154 @@
+import React, { Component } from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:40Z

@@ -0,0 +1,299 @@
+/* eslint-disable no-undef */
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:40Z

@@ -0,0 +1,24 @@
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:41Z

@@ -0,0 +1,188 @@
+// /* eslint-disable */
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:42Z

@@ -0,0 +1,43 @@
+import axios from 'axios';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:42Z

@@ -0,0 +1,30 @@
+import axios from 'axios';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:42Z

@@ -0,0 +1,37 @@
+import axios from 'axios';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:43Z

@@ -0,0 +1,55 @@
+import { batchActions } from 'redux-batched-actions';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-26T18:59:43Z

@@ -0,0 +1,30 @@
+import axios from 'axios';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T00:41:21Z

@@ -0,0 +1,25 @@
+import validator from 'validator';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T00:41:21Z

+    password: process.env.DB_PASSWORD,
+    database: process.env.DB_DATABASE_LOCAL_TEST,
+    host: process.env.DB_HOST,
+    port: process.env.DB_PORT,


'process' is not defined no-undef

houndci-bot · 2018-01-27T00:41:22Z

+    username: process.env.DB_USERNAME,
+    password: process.env.DB_PASSWORD,
+    database: process.env.DB_DATABASE_LOCAL_TEST,
+    host: process.env.DB_HOST,


'process' is not defined no-undef

houndci-bot · 2018-01-27T00:41:22Z

+  test_dev: {
+    username: process.env.DB_USERNAME,
+    password: process.env.DB_PASSWORD,
+    database: process.env.DB_DATABASE_LOCAL_TEST,


'process' is not defined no-undef

houndci-bot · 2018-01-27T00:41:22Z

  },
+  test_dev: {
+    username: process.env.DB_USERNAME,
+    password: process.env.DB_PASSWORD,


'process' is not defined no-undef

houndci-bot · 2018-01-27T00:41:22Z

@@ -1,76 +1,140 @@
+import jwtDecode from 'jwt-decode';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T00:41:23Z

@@ -0,0 +1,16 @@
+module.exports = {


'module' is not defined no-undef

houndci-bot · 2018-01-27T00:41:23Z

@@ -0,0 +1,37 @@
+import validator from 'validator';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T00:41:23Z

@@ -0,0 +1,38 @@
+/* eslint-disable max-len */
+import expect from 'expect';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T00:41:23Z

@@ -0,0 +1,69 @@
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T06:51:58Z

@@ -0,0 +1,37 @@
+import validator from 'validator';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T06:51:58Z

+  devtool: 'source-map',
+  entry: [path.join(__dirname, './client/index.js')],
+  output: {
+    path: path.join(__dirname, 'dist'),


'__dirname' is not defined no-undef

houndci-bot · 2018-01-27T06:51:58Z

+module.exports = {
+
+  devtool: 'source-map',
+  entry: [path.join(__dirname, './client/index.js')],


'__dirname' is not defined no-undef

houndci-bot · 2018-01-27T06:51:58Z

+  }
+});
+
+module.exports = {


'module' is not defined no-undef

houndci-bot · 2018-01-27T06:51:58Z

+const webpack = require('webpack');
+const HtmlWebpackPlugin = require('html-webpack-plugin');
+const CompressionPlugin = require('compression-webpack-plugin');
+const ExtractTextPlugin = require('extract-text-webpack-plugin');


'require' is not defined no-undef

houndci-bot · 2018-01-27T06:51:59Z

+  };
+};
+
+export default validateId;


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

Use Number.isNaN in stead of NaN (line 8)

houndci-bot · 2018-01-27T06:51:59Z

@@ -0,0 +1,63 @@
+import faker from 'faker';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T06:51:59Z

@@ -0,0 +1,260 @@
+import chai, { expect } from 'chai';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T06:52:00Z

@@ -0,0 +1,3 @@
+import './usersController.spec';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T06:52:00Z

@@ -0,0 +1,81 @@
+import chai, { expect } from 'chai';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T06:58:41Z

@@ -0,0 +1,52 @@
+import validator from 'validator';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T06:58:41Z

@@ -0,0 +1,82 @@
+/* eslint-disable react/jsx-filename-extension */
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T07:03:10Z

@@ -0,0 +1,148 @@
+import React, { Component } from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-27T07:03:10Z

@@ -0,0 +1,140 @@
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

segunolalive

Greate job.

See comments.

Also, when exporting singletons/bare-objects as in the case of your controllers, use Pascal case naming

segunolalive · 2018-01-26T19:02:23Z

-    ]
+    ],
+    "plugins": ["transform-object-rest-spread", "emotion"]
 }


It's good practice to end files with a blank line.

Without a blank line at the end, a shell script might be unable to read the last line of code.

segunolalive · 2018-01-26T19:03:23Z

@@ -1,2 +0,0 @@
-SECRET_TOKEN=supersecret
-DB_URL=postgres://xouvfgrs:MIhorjtYuPrb4yJRSgwELbJPytZb0PJ_@elmer.db.elephantsql.com:5432/xouvfgrs


Same as above. Fix all occurrences where the EOF empty line is missing

segunolalive · 2018-01-26T19:07:16Z

 <p align="center">
-    <img src="https://travis-ci.org/fuchodeveloper/more-recipes.svg?branch=master" alt="travis ci build test badge" />
-    <a href='https://coveralls.io/github/fuchodeveloper/more-recipes?branch=master'><img src='https://coveralls.io/repos/github/fuchodeveloper/more-recipes/badge.svg?branch=master' alt='Coverage Status' /></a>
+    <img src="https://travis-ci.org/fuchodeveloper/more-recipes.svg?branch=develop" alt="travis ci build test badge" />


It's not advisable to use mark up in your markdown files. Change these to appropriate markdown syntax

segunolalive · 2018-01-26T19:08:59Z

 </p>

-## More-recipes
+## More-recipes 


The first markdown tag should correspond to an h1 tag. That is, # and is preferably placed at the top of the file

segunolalive · 2018-01-26T19:17:28Z

+ * @export  setCurrentUserError
+ * @param   {object} error - the error that occurred while signing up
+ *
+ * @returns {object} error - the error details from the server


You can only have one return value. You are using a wrong jsdoc syntax to document object property types.

Take a look at this

segunolalive · 2018-01-27T09:15:59Z

+import Adapter from 'enzyme-adapter-react-16';
+import expect from 'expect';
+import { LoginPage } from '../../../components/auth/LoginPage';
+// import mockLocalStorage from '../../__mocks__/mockLocalStorage';


segunolalive · 2018-01-27T09:17:29Z

@@ -0,0 +1,64 @@
+13:00:57.528 INFO - Selenium build info: version: '3.8.1', revision: '6e95a6684b'


this should not be in version control

segunolalive · 2018-01-27T09:21:17Z

@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8" ?>


This should not in version control

segunolalive · 2018-01-27T09:25:11Z

-      ingredient: request.body.ingredient.trim().toLowerCase(),
-      recipeDirection: request.body.recipeDirection.trim().toLowerCase(),
-      recipeImage: request.body.recipeImage
+      name: request.body.name.trim().toLowerCase(),


Good place to use object destructuring syntax

segunolalive · 2018-01-27T09:27:46Z

-            recipeDirection: body.recipeDirection.trim().toLowerCase(),
-            recipeImage: body.recipeImage
+            name: name ? name : recipe.name,
+            ingredients: ingredients ? ingredients : recipe.body,


you can use the logical OR operator here. ||

segunolalive · 2018-01-27T09:38:13Z

Fix Hound CI issues as well

houndci-bot · 2018-01-28T22:51:58Z

@@ -0,0 +1,171 @@
+import chai, { expect } from 'chai';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T22:51:58Z

@@ -0,0 +1,118 @@
+import chai, { expect } from 'chai';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:22:58Z

@@ -0,0 +1,94 @@
+import chai, { expect } from 'chai';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:22:58Z

@@ -0,0 +1,177 @@
+import { mapKeys } from 'lodash';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:22:59Z

@@ -0,0 +1,326 @@
+/* eslint-disable no-undef */
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:22:59Z

@@ -0,0 +1,14 @@
+import { SET_FETCHING, UNSET_FETCHING } from '../action/types';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:22:59Z

@@ -0,0 +1,59 @@
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:22:59Z

@@ -0,0 +1,231 @@
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:43:29Z

@@ -0,0 +1,47 @@
+import expect from 'expect';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

- refactor serverside files: usersController, favoritesController, votesController, recipesController - update users model file: changed recipes model coulmn names to singular names - update backend tests for: usersController, favoritesController, recipesController, votesController - update project JSDoc conventions - remove console logs and dev comments - changed votesController logic to make more readable - changed recipe placeholder image - added validations: for recipes, users - removed logged files - refactor config.js file to use environment variables - update codeclimate.yml file with new config - add parserOption to .eslintrc file - implement more feedback from fellow reviews

houndci-bot · 2018-01-28T23:46:11Z

@@ -0,0 +1,36 @@
+/* eslint-disable react/jsx-filename-extension */
+import React from 'react';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:46:11Z

@@ -0,0 +1,11 @@
+import expect from 'expect';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:46:12Z

@@ -0,0 +1,38 @@
+/* eslint-disable max-len */
+import expect from 'expect';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:46:12Z

@@ -0,0 +1,10 @@
+const localStorage = {};
+
+export default {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:46:12Z

@@ -0,0 +1,30 @@
+import {


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

houndci-bot · 2018-01-28T23:46:12Z

+
+};
+
+export default mockData;


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

fuchodeveloper and others added 30 commits November 12, 2017 10:22

Merge pull request #62 from fuchodeveloper/review-server-api

f74a5f1

#152782762 review api endpoints and refactor where necessary - start implementing refactored API documentation

(ch): cleanup

d2159bd

- code cleanup - add hound.yml file

Merge pull request #65 from fuchodeveloper/ch-refactor-recipe-views-1…

842a1f5

…51251709 Cleanup

(ch): server API review

85d2061

- refactore docs server host - check status codes - refactor function names to fit convention

Merge pull request #66 from fuchodeveloper/ch-review-prepare

ed0e4be

(ch): server API review

(ch): refactore tests

1c01321

implement code review feedback add faker for tests refactor up upvotes action refactor get all recipes and sort recipes route

Merge pull request #67 from fuchodeveloper/ch-review-prepare

3097418

(ch): refactor tests

(bg): travisci-test-fix

88c3752

(bg): travisci yml update

5b54a12

(bg): travisci yml database port update

9a84654

(bg): travisci yml database env for test update

5f81915

(bug): travis test fix

0beae58

(bg): remove node_env from test in package.json

26643e2

(bg): remove node_env from test in package.json

0a703ac

Merge pull request #72 from fuchodeveloper/ch-implement-more-feedback

b9905ea

Ch implement more feedback

ch(client): refactor view a recipe

ee9f721

- follow conventions in app setup test config for local and remote test global loader type for components

Merge pull request #73 from fuchodeveloper/ch-implement-more-feedback

e0a46f2

refactor client view recipe

feedback and initial frontend implementation

4461f47

Merge pull request #74 from fuchodeveloper/ch-implement-more-feedback

0f65f27

feedback and initial frontend implementation

(feature): add pagination to application

4b5e96e

Finishes #151251426

Merge pull request #75 from fuchodeveloper/feature/151251426/implemen…

d81b659

…t-app-pagination #151251426 - User should be able to navigate the app using pagination

(feature): retrieve favorited recipes

7189d9b

Merge pull request #76 from fuchodeveloper/feature/151246935/retrieve…

64461ec

…-favorited-recipes #151246935 - User should be able to retrieve favorited recipes

chore(refactor-app-conventions): refactor app to follow recommended c…

d51c9c0

…onventions and best practices Finishes #154322898

chore(app-conventions): update application to follow airbnb best prac…

d6db6b5

…tices

Merge pull request #77 from fuchodeveloper/chore/154322898/refactor-a…

3060306

…pp-conventions #154322898 - refactor app conventions

update frontend tests

1d4618d

chore(webpack-config): initial setup for production webpack

e5a51b3

chore(webpack-config): configure webapck for production

6a3b454

- create production configuration for webpack - update app entry file to use production configuration - files refactoring

chore(webpack-fix): fix webpack

dd973c5

fuchodeveloper added 4 commits January 17, 2018 22:37

bug(page-crash): fix page crash on unexpected error

2c70928

- add higher order component to catch errors - refactor files Finishes #154422313

bug(fix-app-breaking): fix app breaking features

22ff088

chore(api-docs-build): include api docs build updated file

fd8b494

fix recipe update link

12d1a7a

houndci-bot reviewed Jan 26, 2018

View reviewed changes

fuchodeveloper temporarily deployed to more-recipes-application January 26, 2018 19:00 Inactive

fuchodeveloper temporarily deployed to more-recipes-application January 26, 2018 19:11 Inactive

fuchodeveloper force-pushed the chore/154672011/feedback-implementation branch from 1536ceb to dab1219 Compare January 27, 2018 00:40

houndci-bot reviewed Jan 27, 2018

View reviewed changes

fuchodeveloper force-pushed the chore/154672011/feedback-implementation branch from dab1219 to a876603 Compare January 27, 2018 06:51

houndci-bot reviewed Jan 27, 2018

View reviewed changes

fuchodeveloper force-pushed the chore/154672011/feedback-implementation branch from a876603 to 31ceccc Compare January 27, 2018 06:58

houndci-bot reviewed Jan 27, 2018

View reviewed changes

fuchodeveloper force-pushed the chore/154672011/feedback-implementation branch from 31ceccc to 761882b Compare January 27, 2018 07:02

houndci-bot reviewed Jan 27, 2018

View reviewed changes

segunolalive reviewed Jan 27, 2018

View reviewed changes

fuchodeveloper force-pushed the chore/154672011/feedback-implementation branch from 761882b to 8b436bc Compare January 28, 2018 22:51

houndci-bot reviewed Jan 28, 2018

View reviewed changes

fuchodeveloper force-pushed the chore/154672011/feedback-implementation branch from 8b436bc to 1443a9e Compare January 28, 2018 23:22

houndci-bot reviewed Jan 28, 2018

View reviewed changes

fuchodeveloper force-pushed the chore/154672011/feedback-implementation branch 3 times, most recently from a334ae0 to 67d15bf Compare January 28, 2018 23:42

houndci-bot reviewed Jan 28, 2018

View reviewed changes

fuchodeveloper force-pushed the chore/154672011/feedback-implementation branch from 67d15bf to 3ebb38f Compare January 28, 2018 23:45

houndci-bot reviewed Jan 28, 2018

View reviewed changes

		@@ -0,0 +1,299 @@
		/* eslint-disable no-undef */
		import React from 'react';

		@@ -0,0 +1,188 @@
		// /* eslint-disable */
		import React from 'react';

		@@ -0,0 +1,55 @@
		import { batchActions } from 'redux-batched-actions';

		@@ -0,0 +1,38 @@
		/* eslint-disable max-len */
		import expect from 'expect';

		@@ -0,0 +1,82 @@
		/* eslint-disable react/jsx-filename-extension */
		import React from 'react';

		@@ -1,2 +0,0 @@
		SECRET_TOKEN=supersecret
		DB_URL=postgres://xouvfgrs:MIhorjtYuPrb4yJRSgwELbJPytZb0PJ_@elmer.db.elephantsql.com:5432/xouvfgrs No newline at end of file

		@@ -0,0 +1,64 @@
		13:00:57.528 INFO - Selenium build info: version: '3.8.1', revision: '6e95a6684b'

		@@ -0,0 +1,326 @@
		/* eslint-disable no-undef */
		import React from 'react';

		@@ -0,0 +1,14 @@
		import { SET_FETCHING, UNSET_FETCHING } from '../action/types';

		@@ -0,0 +1,36 @@
		/* eslint-disable react/jsx-filename-extension */
		import React from 'react';

Conversation

fuchodeveloper commented Jan 26, 2018

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Questions:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

segunolalive left a comment

Choose a reason for hiding this comment