Skip to content

Don't create PR for noop migration#505

Merged
maffe03 merged 1 commit intomainfrom
no_empty_migrations
Apr 1, 2026
Merged

Don't create PR for noop migration#505
maffe03 merged 1 commit intomainfrom
no_empty_migrations

Conversation

@maffe03
Copy link
Copy Markdown
Member

@maffe03 maffe03 commented Mar 30, 2026

Currently our CI detection for migrations without changes is broken as it expects the files to remain unchanged. This PR stops Alembic from generating the migration file, hopefully solving the issue and clearing up our PRs!

@maffe03 maffe03 requested a review from georgelgeback March 30, 2026 20:00
@georgelgeback
Copy link
Copy Markdown
Contributor

Why write to a github variable we don't have/use?

@maffe03
Copy link
Copy Markdown
Member Author

maffe03 commented Mar 31, 2026

Just left it there in case we want to use it in the future. It was mostly left there from a previous attempt before I realized it wasn't necessary.

Copy link
Copy Markdown
Contributor

@georgelgeback georgelgeback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maffe03 maffe03 merged commit a434110 into main Apr 1, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants