Skip to content

Revert "Horrible fix for cross site badness" #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HellFelix merged 2 commits into from
Mar 30, 2026
Merged

Revert "Horrible fix for cross site badness" #503

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b0ae64
Revert "Horrible fix for cross site badness (#501)"
georgelgeback Mar 30, 2026
f69be0f
use regex
georgelgeback Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 3 additions & 16 deletions main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,26 +48,11 @@ async def lifespan(app: FastAPI):
no_docs = os.getenv("ENVIRONMENT") == "production"

dev_origins = [
"http://localhost:3000", # If we don't specify port, it defaults to 80
"http://127.0.0.1:3000",
"http://localhost:3001", # Sometimes VSCode thinks 3000 is used, so the frontend uses a higher port
"http://127.0.0.1:3001", # Wildcard ports don't work with cookies so we need this cursed mess :(
"http://localhost:3002",
"http://127.0.0.1:3002",
"http://localhost:3003",
"http://127.0.0.1:3003",
"http://localhost", # Idk if this is even needed
]

stage_origins = [
"https://stage.frontend.fsektionen.se",
"http://localhost:3000", # If we don't specify port, it defaults to 80
"http://127.0.0.1:3000",
"http://localhost:3001", # Sometimes VSCode thinks 3000 is used, so the frontend uses a higher port
"http://127.0.0.1:3001",
"http://localhost:3002",
"http://127.0.0.1:3002",
"http://localhost:3003",
"http://127.0.0.1:3003",
]

production_origins = ["https://fsektionen.se"]
Expand All @@ -86,6 +71,7 @@ async def lifespan(app: FastAPI):
allow_credentials=True,
allow_methods=["*"],
allow_headers=["*"],
allow_origin_regex="\bhttp://(localhost|127\.0\.0\.1):(\d+)\b", # Allow all localhost origins with any port
)

if os.getenv("ENVIRONMENT") == "stage":
Expand All @@ -95,6 +81,7 @@ async def lifespan(app: FastAPI):
allow_credentials=True,
allow_methods=["*"],
allow_headers=["*"],
allow_origin_regex="\bhttp://(localhost|127\.0\.0\.1):(\d+)\b", # Allow all localhost origins with any port
)

if os.getenv("ENVIRONMENT") == "production":
Expand Down
Loading