Finom engine#95
Open
BPere wants to merge 1 commit into
Open
Conversation
fruitl00p
reviewed
Mar 27, 2026
Owner
fruitl00p
left a comment
fruitl00p
left a comment
There was a problem hiding this comment.
Thanks for the added engine. I do have some comments before it can be merged in though.
| namespace Kingsquare\Parser\Banking\Mt940\Engine; | ||
|
|
||
| use Kingsquare\Banking\Statement; | ||
| use Kingsquare\Banking\Hsbc\HsbcTransaction; |
Owner
There was a problem hiding this comment.
Seems like this doesnt belong here?
| $data = $this->getCurrentStatementData(); | ||
| if (preg_match('/:25:FNOM([^:\r\n]+)/', $data, $results) && $results[1] !== '') { | ||
| $account = trim(preg_replace('/EUR\s*$/i', '', trim($results[1]))); | ||
| return trim($account); |
| } | ||
|
|
||
| /** | ||
| * Overloaded: Is applicable if first line starts with :20:AI. |
Owner
There was a problem hiding this comment.
the comment doesn't match the actual code
| $this->engine->loadString(file_get_contents(__DIR__ . '/sample')); | ||
| } | ||
|
|
||
| public function testParseStatementBank() |
Owner
There was a problem hiding this comment.
I'd really like to see a full test suite covering all the various overloaded methods to ensure the correct parsing of the statements themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine parser for the FINOM MT940 file format