Conversation
Consumers should not fetch aspect_rules_lint; it is only used for //tools:format. Map TESTBRIDGE_TEST_ONLY to Vitest testNamePattern so `bazel test --test_filter` does not silently run the whole suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
aspect_rules_lintis only used for//tools:format, but 0.2.3 lists it as a runtimebazel_dep. Consumers then fetchdownload_utilsfrom gitlab.arm.com even when they never load lint. Separately, the sequencer only implements Bazel sharding, sobazel test --test_filter(TESTBRIDGE_TEST_ONLY) is ignored and the whole suite runs. Passing--testNamePatternas ajs_testargs Make fragment fails when the env var is unset: Vitest treats the unexpanded string as a file filter and collects no tests.What
Mark
aspect_rules_lintasdev_dependency = Trueso it stays available for format in this repo and is not forced on consumers. Settest.testNamePatternfromTESTBRIDGE_TEST_ONLYin the generated Vitest config (the config already runs at test time with the env). Document--test_filterin troubleshooting.