Skip to content

fix(ci): fix GNU sed syntax in Pdoc workflow and add manual trigger #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
245678000000 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ci): fix GNU sed syntax in Pdoc workflow and add manual trigger #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/pdoc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,9 @@ name: Pdoc

on:
push:
tags:
- v*.*.*
tags:
- v*.*.*
workflow_dispatch:

@mlissner mlissner Aug 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's up with this?


jobs:
build:
Expand Down Expand Up @@ -35,7 +36,7 @@ jobs:
- name: Run sed # Removes insanely-long parameter definition from docs
working-directory: ./api_documentation
run: |
sed -i '' -E 's#(AhocorasickTokenizer\().*(markup_text:)#\1),<br>\2#g' eyecite/find.html eyecite/index.html
sed -i -E 's#(AhocorasickTokenizer\().*(markup_text:)#\1),<br>\2#g' eyecite/find.html eyecite/index.html

- name: Deploy 🚀
uses: JamesIves/github-pages-deploy-action@v4
Expand Down
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ Changes:
- CI: benchmark runs are superseded when a PR is updated, time out after 15 minutes, and pin their third-party action to a commit SHA. #332

Fixes:
- CI: fix `sed` invocation syntax in the Pdoc workflow on GNU/Linux runners and
add `workflow_dispatch` trigger. #316
- CI: harden the benchmark's `repository_dispatch` job against shell script
injection by passing `client_payload` values through the environment and
validating their shape, instead of interpolating them into `run:`. #337
Expand Down
Loading