Fail closed during interception#178
Draft
lsd-cat wants to merge 2 commits into
Draft
Conversation
Member
|
Nice! Looks like a solid approach, no objections from me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to implement fixes for #176. Basically, while I hope we've fixed the race conditions, the underlying problems is also that on throws the default behavior is to pass the request or content through. I think we should rather always drop in case of WEBCAT errors. In that way, if someone defies our logic, they are stuck with a DoS instead of a bypass.
The first commit here implements this only for the streamFilter, while similar behavior should be applied to the request interceptor and the headers validator. The alternative to one big try catch is a wrapper function, but I find that less readable. Curious if that looks reasonable to you @jupenur and in case I'll improve coverage before being ready.