WIP: Add more basic tests#144
Draft
lsd-cat wants to merge 2 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discusses elsewhere, integration tests are slow and it's pretty easy to test individual functions using
vitestas we already do. This draft PRs aims to collect some more of these tests to add to the suite. In general these tests cases are also easier to AI generate.I'm starting with tests for the OriginState class and will add more while PR is in draft. OriginState reminds me that there's also behavior that was never tested, such as the fallback manifest logic and the possibility of signaling manifest updates.