Repository navigation
Fix full-width ASUS Dial reports and held-rotation ordering - #10
Merged
Merged
Conversation
Decode 01/0A reports as signed 16-bit little-endian deltas. Emit button edges before held rotation and after release rotation, retaining Rotate(i)/Press(i). Ignore unrelated reports and exit on disconnected input so a session supervisor can reconnect. Add a notification opt-out and standalone report regression tests. Signed-off-by: Lightmarey <lightmarey007@gmail.com>
Install D-Bus and Qt development packages on the runner. Fail configuration for missing required dependencies and verify that requested executables were built and installed. Keep daemon-only checks independent of Qt and run the rotation tests without a display. Signed-off-by: Lightmarey <lightmarey007@gmail.com>
Keep the full delta on D-Bus while feeding the legacy gadget one tick per accepted report. Check both packet formats in Release tests and report device open, disconnect and read failures separately. Signed-off-by: Lightmarey <lightmarey007@gmail.com>
Signed-off-by: Lightmarey <lightmarey007@gmail.com>
Lightmarey
force-pushed
the
codex/input-reports
branch
from
November 18, 2026 08:35
fc77564 to
76d40b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASUS Dial HID reports carry signed 16-bit rotation deltas. Reading only the low byte loses larger rotations. When a press and rotation arrive in the same report, consumers need the press first to interpret that rotation as held input.
Changes
0x01and0x0aand forward the full delta throughorg.asus.dial.Rotate(i). EmitPress(1)before a rotation on press andPress(0)after a rotation on release. The existing D-Bus name, path and signal signatures are preserved.--no-notifyto suppress the startup notification when a frontend handles feedback.Validation
0x0a. Coverage for0x01and large deltas uses synthetic reports.