Skip to content

Fix full-width ASUS Dial reports and held-rotation ordering - #10

Merged
fredaime merged 4 commits into
fredaime:mainfrom
Lightmarey:codex/input-reports
Nov 18, 2026
Merged

fredaime merged 4 commits into
fredaime:mainfrom
Lightmarey:codex/input-reports

Conversation

@Lightmarey

@Lightmarey Lightmarey commented Oct 4, 2026 •

Copy link
Copy Markdown
Contributor

ASUS Dial HID reports carry signed 16-bit rotation deltas. Reading only the low byte loses larger rotations. When a press and rotation arrive in the same report, consumers need the press first to interpret that rotation as held input.

Changes

  • Decode reports 0x01 and 0x0a and forward the full delta through org.asus.dial.Rotate(i). Emit Press(1) before a rotation on press and Press(0) after a rotation on release. The existing D-Bus name, path and signal signatures are preserved.
  • Feed the existing Qt gadget one signed tick per report so its thresholds and synchronous actions keep their existing behavior. Other D-Bus consumers receive the full delta.
  • Exit with failure on device loss so a session supervisor can restart the daemon. Use --no-notify to suppress the startup notification when a frontend handles feedback.
  • Install the development dependencies in the Ubuntu 24.04 workflow and verify that the requested binaries build and install. The daemon-only job runs without Qt. The rotation test now works independently of runner timing.

Validation

  • Local Release builds passed all 2 daemon-only and 4 daemon + Qt CTest entries. The Qt rotation suite passed 25 consecutive runs.
  • C tests cover both report IDs, signed boundaries, repeated held reports, press/rotation/release ordering and malformed reports. The earlier ASUS2020 hardware capture covered 0x0a. Coverage for 0x01 and large deltas uses synthetic reports.

@Lightmarey Lightmarey closed this Oct 4, 2026
@fredaime fredaime reopened this Oct 4, 2026
@Lightmarey Lightmarey changed the title Fix full-width dial reports and held-rotation event ordering Fix full-width ASUS Dial reports and held-rotation ordering Nov 18, 2026
Decode 01/0A reports as signed 16-bit little-endian deltas. Emit button edges before held rotation and after release rotation, retaining Rotate(i)/Press(i). Ignore unrelated reports and exit on disconnected input so a session supervisor can reconnect.

Add a notification opt-out and standalone report regression tests.

Signed-off-by: Lightmarey <lightmarey007@gmail.com>
Install D-Bus and Qt development packages on the runner. Fail configuration for missing required dependencies and verify that requested executables were built and installed. Keep daemon-only checks independent of Qt and run the rotation tests without a display.

Signed-off-by: Lightmarey <lightmarey007@gmail.com>
Keep the full delta on D-Bus while feeding the legacy gadget one tick per accepted report. Check both packet formats in Release tests and report device open, disconnect and read failures separately.

Signed-off-by: Lightmarey <lightmarey007@gmail.com>
Signed-off-by: Lightmarey <lightmarey007@gmail.com>
@fredaime
fredaime merged commit 3437eaa into fredaime:main Nov 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants