Complete type safety across all JS/TS#105
Merged
Merged
Conversation
|
🌐 Preview URL: https://pr-105.frcsoftware.pages.dev |
github-actions
Bot
added
the
infra
samfreund
reviewed
Jul 22, 2026
3 tasks
httphypixelnet
added a commit
to httphypixelnet/frcsoftware.org
that referenced
this pull request
Jul 22, 2026
github-actions
Bot
added
the
Curriculum material
github-actions
Bot
removed
the
Curriculum material
zachwaffle4
force-pushed
the
fix/type-safety
branch
from
July 23, 2026 16:14
fe9e60c to
a75619f
Compare
samfreund
reviewed
Jul 23, 2026
samfreund
reviewed
Jul 23, 2026
Member
|
otherwise lgtm |
samfreund
self-requested a review
July 25, 2026 07:10
samfreund
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bring us one step closer to complete type safety. Before, we weren't checking JavaScript files (including inline scripts in our starlight override components) which is bad 👍. Also set tsconfig preset to strictest.