Repository navigation
fix: pre-bundle every prosemirror package so TextEditor and frappe-ui/editor share one copy - #292
Merged
Merged
Conversation
…/editor share one copy frappe-ui's editor .vue files load unbundled in dev and import prosemirror from node_modules, while frappe-ui/editor's pre-bundle inlines its own. Once both load on one page (the global TextEditor plus an @framework/ui ActivityTimeline), the second copy re-registers its IDs and rendering fails with "Duplicate use of selection JSON ID gapcursor". Pinning only the four core packages left gapcursor, tables and the rest duplicated.
Contributor
 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ActivityTimeline failed to load in dev mode with an error Duplicate use of selection JSON
ID gapcursor