Open
Conversation
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com>
Author
|
@frankban Can you please review this PR? |
frankban
approved these changes
Feb 20, 2025
Owner
frankban
left a comment
frankban
left a comment
There was a problem hiding this comment.
Looks good with a question. Thanks!
| } | ||
| } | ||
|
|
||
| func TestBinaryArithmeticCheckerValidation(t *testing.T) { |
Owner
There was a problem hiding this comment.
Do we need all these tests? Isn't one test for the value and one for the reference sufficient? Also, can this be just part of the checker tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following checkers:
IsLessThanIsLessThanOrEqualIsGreaterThanIsGreaterThanOrEqualThese new checkers are based on a new generic binary arithmetic operator checker, named
binaryArithmeticChecker, which converts operands to*big.Floatvalues for simple comparison.