Skip to content

Fix pin ergonomics pretty test for direct pin_v2 rule#3

Closed
P8L1 wants to merge 1 commit intofrank-king:feature/pin-borrowckfrom
P8L1:fix-pretty-pin-ergonomics-ci
Closed

Fix pin ergonomics pretty test for direct pin_v2 rule#3
P8L1 wants to merge 1 commit intofrank-king:feature/pin-borrowckfrom
P8L1:fix-pretty-pin-ergonomics-ci

Conversation

@P8L1
Copy link
Copy Markdown

@P8L1 P8L1 commented Apr 29, 2026

Summary

Fix the stage-2 pretty test failure in tests/pretty/pin-ergonomics.rs after adding the direct &pin / #[pin_v2] rule.

The test directly pins Foo with &pin mut Foo and &pin const Foo, but Foo was still a plain ADT. Since direct pinning of ADTs now requires #[pin_v2], the pretty-printed source no longer typechecked.

This PR marks Foo as #[pin_v2] so the pretty test remains valid while preserving the new diagnostic behavior.

Tests

Passed:

./x test tests/pretty/pin-ergonomics.rs --stage 2 --test-args --force-rerun
./x test tests/pretty/pin-ergonomics-hir.rs --stage 2 --test-args --force-rerun
./x test tests/pretty --stage 2 --test-args pin-ergonomics --force-rerun
./x test tests/ui/pin-ergonomics --stage 2 --test-args --force-rerun
./x test --stage 2 --skip tidy --skip compiler --skip src
git diff --check
./x fmt --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant