Fix pin ergonomics pretty test for direct pin_v2 rule#3
Closed
P8L1 wants to merge 1 commit intofrank-king:feature/pin-borrowckfrom
Closed
Fix pin ergonomics pretty test for direct pin_v2 rule#3P8L1 wants to merge 1 commit intofrank-king:feature/pin-borrowckfrom
P8L1 wants to merge 1 commit intofrank-king:feature/pin-borrowckfrom
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the stage-2 pretty test failure in
tests/pretty/pin-ergonomics.rsafter adding the direct&pin/#[pin_v2]rule.The test directly pins
Foowith&pin mut Fooand&pin const Foo, butFoowas still a plain ADT. Since direct pinning of ADTs now requires#[pin_v2], the pretty-printed source no longer typechecked.This PR marks
Fooas#[pin_v2]so the pretty test remains valid while preserving the new diagnostic behavior.Tests
Passed: