Skip to content

Update agentos-workbench backend to agentos v0.1.3#2

Open
Victor-Evogor wants to merge 4 commits intoframersai:masterfrom
Victor-Evogor:master
Open

Update agentos-workbench backend to agentos v0.1.3#2
Victor-Evogor wants to merge 4 commits intoframersai:masterfrom
Victor-Evogor:master

Conversation

@Victor-Evogor
Copy link
Contributor

@Victor-Evogor Victor-Evogor commented Dec 17, 2025

Description:

This PR updates the @framers/agentos dependency in the workbench backend to use the latest released version 0.1.3.

Changes:

  • agentos-workbench/backend/package.json: Updated @framers/agentos from file:../../ to 0.1.3.
  • agentos-workbench/backend/pnpm-lock.yaml: Updated lockfile to reflect the new dependency version.

Reasoning:

Switching from a local file reference to a specific version number ensures reproducible builds and aligns the workbench with the latest stable release of the core library.

Verification:

  • pnpm install ran successfully.
  • pnpm run build passed.

Summary by Sourcery

Update the backend to use the released @framers/agentos v0.1.3 and remove mock-backed placeholder data from API routes.

Enhancements:

  • Replace mock responses in agent, evaluation, and marketplace routes with empty placeholder data and explicit TODOs in preparation for real AgentOS-backed implementations.
  • Simplify the agency execution detail endpoint to consistently return a 404 placeholder response until real execution data is wired up.

Build:

  • Pin @framers/agentos dependency in the backend to version 0.1.3 instead of a local file reference.

Chores:

  • Remove unused mockData and related type definitions from the backend source.

@sourcery-ai
Copy link

sourcery-ai bot commented Dec 17, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the backend to use @framers/agentos v0.1.3 instead of a local file dependency, removes local mock data/types, and adjusts several Fastify routes to return empty placeholder data or 404s with TODOs until real AgentOS-backed implementations are available.

Sequence diagram for updated agency execution detail route behavior

sequenceDiagram
  actor User
  participant WorkbenchBackend
  participant FastifyRoute_agencyExecutionDetail

  User->>WorkbenchBackend: GET /api/agentos/agencies/{agencyId}/executions/{executionId}
  WorkbenchBackend->>FastifyRoute_agencyExecutionDetail: invoke handler
  activate FastifyRoute_agencyExecutionDetail
  FastifyRoute_agencyExecutionDetail->>FastifyRoute_agencyExecutionDetail: set reply status 404
  FastifyRoute_agencyExecutionDetail-->>WorkbenchBackend: { statusCode: 404, message: Execution not found }
  deactivate FastifyRoute_agencyExecutionDetail
  WorkbenchBackend-->>User: HTTP 404 { statusCode: 404, message: Execution not found }
Loading

Sequence diagram for updated list routes returning empty placeholder data

sequenceDiagram
  actor User
  participant WorkbenchBackend
  participant AgentosRoutes
  participant EvaluationRoutes
  participant MarketplaceRoutes

  User->>WorkbenchBackend: GET /api/agentos/extensions
  WorkbenchBackend->>AgentosRoutes: handle extensions request
  AgentosRoutes-->>WorkbenchBackend: []
  WorkbenchBackend-->>User: HTTP 200 []

  User->>WorkbenchBackend: GET /api/agentos/tools
  WorkbenchBackend->>AgentosRoutes: handle tools request
  AgentosRoutes-->>WorkbenchBackend: []
  WorkbenchBackend-->>User: HTTP 200 []

  User->>WorkbenchBackend: GET /api/agentos/models
  WorkbenchBackend->>AgentosRoutes: handle models request
  AgentosRoutes-->>WorkbenchBackend: { models: [] }
  WorkbenchBackend-->>User: HTTP 200 { models: [] }

  User->>WorkbenchBackend: GET /api/agentos/guardrails
  WorkbenchBackend->>AgentosRoutes: handle guardrails request
  AgentosRoutes-->>WorkbenchBackend: []
  WorkbenchBackend-->>User: HTTP 200 []

  User->>WorkbenchBackend: GET /api/agentos/executions
  WorkbenchBackend->>AgentosRoutes: handle executions list request
  AgentosRoutes-->>WorkbenchBackend: { executions: [] }
  WorkbenchBackend-->>User: HTTP 200 { executions: [] }

  User->>WorkbenchBackend: GET /api/evaluation/runs
  WorkbenchBackend->>EvaluationRoutes: handle evaluation runs request
  EvaluationRoutes-->>WorkbenchBackend: []
  WorkbenchBackend-->>User: HTTP 200 []

  User->>WorkbenchBackend: GET /api/marketplace/items
  WorkbenchBackend->>MarketplaceRoutes: handle marketplace items request
  MarketplaceRoutes-->>WorkbenchBackend: []
  WorkbenchBackend-->>User: HTTP 200 []
Loading

File-Level Changes

Change Details Files
Switch backend dependency on @framers/agentos from a local file reference to the published 0.1.3 release and refresh lockfile.
  • Update dependency spec for @framers/agentos to version 0.1.3 in the backend package manifest.
  • Regenerate pnpm-lock.yaml entries so they align with the new @framers/agentos version.
backend/package.json
backend/pnpm-lock.yaml
Replace mock data responses in AgentOS-related routes with empty placeholders and TODOs, aligning behavior with the new agentos integration expectations.
  • Change extensions, tools, models, guardrails, and executions list endpoints to return empty arrays/objects with TODO comments instead of mock data.
  • Adjust the agency execution detail endpoint to always return a 404 with a structured error object, replacing mock lookup by agencyId.
backend/src/routes/agentos.ts
Disable mock evaluation and marketplace data by returning empty results from their respective routes.
  • Update evaluation runs endpoint to return an empty array and add a TODO for future implementation.
  • Update marketplace items endpoint to return an empty array and add a TODO for future implementation.
backend/src/routes/evaluation.ts
backend/src/routes/marketplace.ts
Remove now-unused mock data and associated types from the backend codebase.
  • Delete the mockData module that contained in-memory mock domain objects.
  • Delete the types module that defined types for mock data structures that are no longer used.
backend/src/mockData.ts
backend/src/types.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Several routes that previously returned mock data now return empty arrays or 404s; if the frontend still depends on the old shapes or non-empty responses, consider adding a transitional flag or feature check to avoid breaking the UI while AgentOS-backed implementations are still pending.
  • In the agencyId execution handler you now manually set reply.code(404) and return a { statusCode, message } object; it would be more consistent with Fastify’s error handling to use reply.notFound() or throw a Fastify error, so errors are handled uniformly across routes.
  • Since mockData and related types have been removed, verify that shared type definitions for responses (e.g., extensions, tools, models, executions) are defined in a central place to avoid ad-hoc typing as you replace the TODO stubs with real AgentOS data.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Several routes that previously returned mock data now return empty arrays or 404s; if the frontend still depends on the old shapes or non-empty responses, consider adding a transitional flag or feature check to avoid breaking the UI while AgentOS-backed implementations are still pending.
- In the `agencyId` execution handler you now manually set `reply.code(404)` and return a `{ statusCode, message }` object; it would be more consistent with Fastify’s error handling to use `reply.notFound()` or throw a Fastify error, so errors are handled uniformly across routes.
- Since mockData and related types have been removed, verify that shared type definitions for responses (e.g., extensions, tools, models, executions) are defined in a central place to avoid ad-hoc typing as you replace the TODO stubs with real AgentOS data.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Updated all workflow files to properly use pnpm package manager:
- Removed npm cache configuration from actions/setup-node
- Added pnpm/action-setup@v4 to install pnpm
- Updated all npm commands to use pnpm equivalents

This fixes the "Dependencies lock file is not found" error that occurred
because the workflows were looking for npm lock files while the project
uses pnpm-lock.yaml.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant