Update agentos-workbench backend to agentos v0.1.3#2
Open
Victor-Evogor wants to merge 4 commits intoframersai:masterfrom
Open
Update agentos-workbench backend to agentos v0.1.3#2Victor-Evogor wants to merge 4 commits intoframersai:masterfrom
Victor-Evogor wants to merge 4 commits intoframersai:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the backend to use @framers/agentos v0.1.3 instead of a local file dependency, removes local mock data/types, and adjusts several Fastify routes to return empty placeholder data or 404s with TODOs until real AgentOS-backed implementations are available. Sequence diagram for updated agency execution detail route behaviorsequenceDiagram
actor User
participant WorkbenchBackend
participant FastifyRoute_agencyExecutionDetail
User->>WorkbenchBackend: GET /api/agentos/agencies/{agencyId}/executions/{executionId}
WorkbenchBackend->>FastifyRoute_agencyExecutionDetail: invoke handler
activate FastifyRoute_agencyExecutionDetail
FastifyRoute_agencyExecutionDetail->>FastifyRoute_agencyExecutionDetail: set reply status 404
FastifyRoute_agencyExecutionDetail-->>WorkbenchBackend: { statusCode: 404, message: Execution not found }
deactivate FastifyRoute_agencyExecutionDetail
WorkbenchBackend-->>User: HTTP 404 { statusCode: 404, message: Execution not found }
Sequence diagram for updated list routes returning empty placeholder datasequenceDiagram
actor User
participant WorkbenchBackend
participant AgentosRoutes
participant EvaluationRoutes
participant MarketplaceRoutes
User->>WorkbenchBackend: GET /api/agentos/extensions
WorkbenchBackend->>AgentosRoutes: handle extensions request
AgentosRoutes-->>WorkbenchBackend: []
WorkbenchBackend-->>User: HTTP 200 []
User->>WorkbenchBackend: GET /api/agentos/tools
WorkbenchBackend->>AgentosRoutes: handle tools request
AgentosRoutes-->>WorkbenchBackend: []
WorkbenchBackend-->>User: HTTP 200 []
User->>WorkbenchBackend: GET /api/agentos/models
WorkbenchBackend->>AgentosRoutes: handle models request
AgentosRoutes-->>WorkbenchBackend: { models: [] }
WorkbenchBackend-->>User: HTTP 200 { models: [] }
User->>WorkbenchBackend: GET /api/agentos/guardrails
WorkbenchBackend->>AgentosRoutes: handle guardrails request
AgentosRoutes-->>WorkbenchBackend: []
WorkbenchBackend-->>User: HTTP 200 []
User->>WorkbenchBackend: GET /api/agentos/executions
WorkbenchBackend->>AgentosRoutes: handle executions list request
AgentosRoutes-->>WorkbenchBackend: { executions: [] }
WorkbenchBackend-->>User: HTTP 200 { executions: [] }
User->>WorkbenchBackend: GET /api/evaluation/runs
WorkbenchBackend->>EvaluationRoutes: handle evaluation runs request
EvaluationRoutes-->>WorkbenchBackend: []
WorkbenchBackend-->>User: HTTP 200 []
User->>WorkbenchBackend: GET /api/marketplace/items
WorkbenchBackend->>MarketplaceRoutes: handle marketplace items request
MarketplaceRoutes-->>WorkbenchBackend: []
WorkbenchBackend-->>User: HTTP 200 []
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- Several routes that previously returned mock data now return empty arrays or 404s; if the frontend still depends on the old shapes or non-empty responses, consider adding a transitional flag or feature check to avoid breaking the UI while AgentOS-backed implementations are still pending.
- In the
agencyIdexecution handler you now manually setreply.code(404)and return a{ statusCode, message }object; it would be more consistent with Fastify’s error handling to usereply.notFound()or throw a Fastify error, so errors are handled uniformly across routes. - Since mockData and related types have been removed, verify that shared type definitions for responses (e.g., extensions, tools, models, executions) are defined in a central place to avoid ad-hoc typing as you replace the TODO stubs with real AgentOS data.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Several routes that previously returned mock data now return empty arrays or 404s; if the frontend still depends on the old shapes or non-empty responses, consider adding a transitional flag or feature check to avoid breaking the UI while AgentOS-backed implementations are still pending.
- In the `agencyId` execution handler you now manually set `reply.code(404)` and return a `{ statusCode, message }` object; it would be more consistent with Fastify’s error handling to use `reply.notFound()` or throw a Fastify error, so errors are handled uniformly across routes.
- Since mockData and related types have been removed, verify that shared type definitions for responses (e.g., extensions, tools, models, executions) are defined in a central place to avoid ad-hoc typing as you replace the TODO stubs with real AgentOS data.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Updated all workflow files to properly use pnpm package manager: - Removed npm cache configuration from actions/setup-node - Added pnpm/action-setup@v4 to install pnpm - Updated all npm commands to use pnpm equivalents This fixes the "Dependencies lock file is not found" error that occurred because the workflows were looking for npm lock files while the project uses pnpm-lock.yaml. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the @framers/agentos dependency in the workbench backend to use the latest released version 0.1.3.
Changes:
Reasoning:
Switching from a local file reference to a specific version number ensures reproducible builds and aligns the workbench with the latest stable release of the core library.
Verification:
Summary by Sourcery
Update the backend to use the released @framers/agentos v0.1.3 and remove mock-backed placeholder data from API routes.
Enhancements:
Build:
Chores: