Skip to content

Fix recording, catalog integrity, UI state and updater audit findings - #8

Merged
fraa2a merged 14 commits into
mainfrom
fix/audit-errors
Oct 19, 2026
Merged

fraa2a merged 14 commits into
mainfrom
fix/audit-errors

Conversation

@fraa2a

@fraa2a fraa2a commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

Implements the approved Monolith audit corrections while preserving the existing native engine, Tauri sidecars and screenshot-based UI.

Recorder integration now includes recording with replay disabled, common capture clocks, deferred settings/target changes, bounded encoded-packet writing, ordered recording/replay boundaries and source-level WASAPI recovery. Native tray/hotkeys have an owned message thread, so media lifecycle and disk drains run outside its message loop. Session bookmarks and completed partial recordings retain publication ownership through retries.

Storage validates current roots and stable clip identities/revisions, serializes recoverable trim operations and restores bookmark recovery sidecars. The UI/host fixes cover settings persistence, timeline guards, current-root media access, thumbnails, collections, selection and readiness. Updater corrections cover signed metadata, process exit/readiness, cancellation, recovery and ordered state events; Stream Deck replies are strictly validated.

Validation:

  • Checkpoint 8b136a7 passed Core regression tests run 13 and Windows CI run 131.
  • Current continuation e67690f (including 2fb952e): portable native phase1 9/9 and phase2 3/3 pass. This includes a stalled real FFmpeg recorder muxer with nonblocking packet admission, ordered stop and a successfully decoded output.
  • Repository text policy and whitespace checks pass. Updated GitHub CI is pending.
  • Prior Rust, frontend/browser, storage, logging, updater ordering and Stream Deck checks are recorded with their exact scope in docs/audit/2026-10-09-fixes.md.

Limits:

  • Real WGC/device replacement/format changes, long-session synchronization, tray responsiveness under hardware failures, WebView2 range/multitrack playback and clean install/update still require Windows smoke testing.
  • Abrupt process loss before finalization writes the bookmark sidecar can still lose live markers. Recoverable trim journaling does not certify power-loss durability.
  • Full UI virtualization/pagination and further recorder responsibility extraction remain deferred optimizations.

Audit matrix: docs/audit/2026-10-09-fixes.md. The PR remains draft while updated Windows verification is pending. No release is part of this change.

@fraa2a
fraa2a marked this pull request as ready for review October 19, 2026 00:47
@fraa2a
fraa2a merged commit 95b3e94 into main Oct 19, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant