Staging/shared module extraction - #1
Merged
Merged
Conversation
…catalog) One body instead of hand-synced copies: apps/shared carries yardauth (moved from hose+valve), the hardening headers (secure.go x3 -> shared/ secure), and the ATT&CK tactic/technique catalog both internal/mitre packages duplicated. Detection stays app-specific — rules-AST conds in the bucket, syslog-ng patterns in the valve — each with a test pinning it to the shared catalog. Apps consume via a replace directive; the root go.work gives gopls one workspace.
…ardAuthApi) apps/shared/web/src now holds the components every SPA duplicated, plus yardAuthApi — the auth/user-management client hose and valve spread into their api objects. The per-app files of the same names are one-line re-export shims, so no import site changed. tsconfig paths pin react to each app's copy for files outside the package; vite resolve.dedupe does the same at bundle time. Rebuilt dists confirm identical output.
Build context moves from apps/<tool> to apps/ (dockerfile: <tool>/Dockerfile, one apps/.dockerignore) so images can copy shared/. CI gains a shared matrix leg and runs GOWORK=off, keeping each module on its own pinned Go version. Quadlet/README build commands, CONTRIBUTING and the suite plan updated; the duplication finding in docs/PLAN.md is recorded as actioned.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
How it was tested
Checklist
go test ./...passes in every touched moduledocs/updated if behavior they describe changeddocs/CREDITS.md