Package Capture independently - #3
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e3f1c0221
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| r"(?i)(?<![A-Za-z0-9/])[A-Z]:[\\/][^\r\n<>\"'`|]+" | ||
| ) | ||
| _UNC_ABSOLUTE = re.compile(r"(?<![\\])\\\\[^\\/\s]+[\\/][^\r\n<>\"'`|]+") | ||
| _POSIX_ABSOLUTE = re.compile(r"(?<![A-Za-z0-9:/])/(?!/)[^\r\n<>\"'`|]+") |
There was a problem hiding this comment.
Redact POSIX paths that follow label colons
When an artifact contains a labelled absolute path such as source:/srv/secret/team/private.pdf, the colon in this negative lookbehind prevents _POSIX_ABSOLUTE from matching it. The complete path therefore persists in research-artifacts.json and is subsequently indexed by search.build, violating the documented path-free ingestion boundary; distinguish URL schemes without excluding every colon-prefixed POSIX path.
Useful? React with 👍 / 👎.
| ) | ||
| _UNC_ABS_RE = re.compile(r"(?<![\\])\\\\[^\\/\s]+[\\/][^\r\n<>\"'`|]+") | ||
| _POSIX_ABS_RE = re.compile( | ||
| r"(?i)(?<![A-Za-z0-9:/])/(?!/)[^\r\n<>\"'`|)\]]+?" |
There was a problem hiding this comment.
Omit colon-prefixed paths from context capsules
For project or library text formatted as source:/srv/secret/team/private.pdf, this lookbehind rejects the path match, and the later generic redactor does not remove it. Both the JSON CLI and MCP capsule can consequently expose the absolute path despite the capsule's stated guarantee that all local paths are omitted.
Useful? React with 👍 / 👎.
| "stage_failed", | ||
| "The project writeback completed but its memory snapshot could not be refreshed.", | ||
| ) | ||
| return report |
There was a problem hiding this comment.
Preserve pending actions when portfolio refresh fails
If the post-writeback vault refresh raises an expected filesystem or decoding error, this direct return bypasses _finish, which is responsible for adding agent-fill, project-resolution, human-approval, and workspace-review actions from the already-populated summary. A partial run can therefore report nonzero pending counts but an empty action_required list, hiding the follow-up work the user still needs to perform.
Useful? React with 👍 / 👎.
What changed
Publishes Provenance as the general project-memory and context engine and adds a dedicated
capture-v*Release workflow. Capture remains owned by the Provenance repository but is built as a deterministic ZIP with an adjacent SHA-256 file for users who only need conversation export.Why
The suite needs one core memory engine while allowing the browser exporter to be downloaded without cloning or installing the full repository.
Validation