Use a single "message" event listener to dispatch received messages#3
Merged
defunctzombie merged 2 commits intoJan 24, 2024
Merged
Conversation
achim-k
commented
Jan 24, 2024
achim-k
commented
Co-authored-by: Roman Shtylman <roman@foxglove.dev>
pezy
pushed a commit
to pezy/studio
that referenced
this pull request
Sep 14, 2024
Update comlink to 9181fa505671b35b1e66e0a8361a6fc1bdd03307 for performance improvements Includes foxglove/comlink#1 and foxglove/comlink#3
achim-k
added a commit
that referenced
this pull request
Jan 13, 2025
### Changelog Fix message ports not being closed when proxy is relased ### Docs None ### Description Fixes a regression introduced #3 that caused the ``` requestResponseMessage(ep, pendingListeners || new Map(), { type: MessageType.RELEASE, }) ``` promise to never settle which in turn prevented the endpoint from being closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.