Skip to content

Remove kb from all mode#254

Merged
soimkim merged 1 commit intomainfrom
slow
Mar 9, 2026
Merged

Remove kb from all mode#254
soimkim merged 1 commit intomainfrom
slow

Conversation

@soimkim
Copy link
Contributor

@soimkim soimkim commented Mar 8, 2026

Description

  • Fixed an issue where the KB scanner would run automatically when selecting 'all' scanners. KB now only executes when explicitly selected.

@soimkim soimkim self-assigned this Mar 8, 2026
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Mar 8, 2026
@coderabbitai
Copy link

coderabbitai bot commented Mar 8, 2026

📝 Walkthrough

Walkthrough

KB execution now runs only when the selected scanner is explicitly kb (removed from the all condition). The display mode for all was updated to exclude KB, listing only scancode and scanoss.

Changes

Cohort / File(s) Summary
KB Execution and Display Mode
src/fosslight_source/cli.py
Restricted KB execution to explicit kb scanner selection (removed from all condition) and adjusted the all display mode string to exclude KB, showing only scancode and scanoss.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Suggested labels

chore

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove kb from all mode' accurately describes the main change in the PR, which explicitly removes KB from the automatic execution when all scanners are selected.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch slow

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/fosslight_source/cli.py`:
- Around line 209-216: The run_kb flag is still being set to True for
selected_scanner == 'all' at the later assignment, causing KB lookups in
merge_results()/set_oss_item even though the earlier logic and display intend to
exclude KB; update the later assignment that sets run_kb (the one currently
using selected_scanner in ['kb','all']) to only enable KB for 'kb' (i.e., use
selected_scanner == 'kb' or selected_scanner in ['kb']) so merge_results() and
set_oss_item will skip KB lookups when selected_scanner == 'all' and the display
remains consistent.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: aff15048-8309-4136-9ae5-ddbe1b797ac6

📥 Commits

Reviewing files that changed from the base of the PR and between 7177ce5 and 35389a4.

📒 Files selected for processing (1)
  • src/fosslight_source/cli.py

@soimkim soimkim merged commit b449928 into main Mar 9, 2026
7 checks passed
@soimkim soimkim deleted the slow branch March 9, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant