Skip to content

Fix tox error #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjk7119 merged 1 commit into from
Mar 11, 2026
Merged

Fix tox error #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions hooks/hook-fosslight_binary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,9 @@
from PyInstaller.utils.hooks import collect_all

datas, binaries, hiddenimports = collect_all('fosslight_binary')

# Collect binaryornot package including data files
datas_binaryornot, binaries_binaryornot, hiddenimports_binaryornot = collect_all('binaryornot')
datas += datas_binaryornot
binaries += binaries_binaryornot
hiddenimports += hiddenimports_binaryornot
1 change: 1 addition & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
binaryornot
chardet<5.0.0
numpy
pandas
parmap
Expand Down
1 change: 1 addition & 0 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ ignore = E722, W503

[pytest]
filterwarnings = ignore::DeprecationWarning
norecursedirs = third_party build dist .tox .git __pycache__
Comment on lines 23 to +25
Copy link

@coderabbitai coderabbitai bot Mar 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "== tox.ini =="
sed -n '1,120p' tox.ini

echo
echo "== requirements-dev wiring =="
fd '^requirements-dev\.txt$' -x sh -c 'echo "--- $1"; sed -n "1,160p" "$1"' sh {}

echo
echo "== GitHub Actions tox invocations =="
if [ -d .github/workflows ]; then
  fd -e yml -e yaml . .github/workflows -x sh -c '
    echo "--- $1"
    rg -n -C2 "\btox\b|test_run|release|requirements-dev|pip install" "$1" || true
  ' sh {}
else
  echo "No .github/workflows directory found"
fi

Repository: fosslight/fosslight_binary_scanner

Length of output: 3810

The default tox environment won't install chardet from the new requirements.txt entry.

The GitHub Actions workflow runs tox -e release (not test_run), and the release environment depends only on -r{toxinidir}/requirements-dev.txt (lines 42–46). Since requirements-dev.txt does not include -r requirements.txt or list chardet explicitly, the new chardet entry in requirements.txt will not be installed into tox. This change set will not fix the tox job unless requirements-dev.txt is updated to include the missing dependency.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@tox.ini` around lines 23 - 25, The tox "release" environment currently only
installs from requirements-dev.txt so the new chardet entry in requirements.txt
is not picked up; update requirements-dev.txt to either include "-r
requirements.txt" or add "chardet" explicitly so the tox "release" env (invoked
by the GitHub Actions workflow using tox -e release) installs the missing
dependency; modify the requirements-dev.txt file accordingly to ensure chardet
is available during the release tox run.


[testenv:test_run]
deps =
Expand Down