Fix: Incorrect time response without place name (#241)#405
Open
LoveChauhan-18 wants to merge 1 commit into
Open
Fix: Incorrect time response without place name (#241)#405LoveChauhan-18 wants to merge 1 commit into
LoveChauhan-18 wants to merge 1 commit into
Conversation
…ck intent to prompt user for location instead of returning default time.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the time intent handling so that time queries without an explicit location use a dedicated intent and fallback clarification response, while only triggering the dynamic API for time queries that include a place name. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #241 where SUSI returned an incorrect default location time when no place name was specified.
Changes:
Now:
• Queries with place return correct time
• Queries without place prompt user for clarification
Kindly review.
Summary by Sourcery
Handle time queries without an explicit location to avoid returning incorrect default times.
Bug Fixes:
Enhancements: