Skip to content

Fix: Incorrect time response without place name (#241)#405

Open
LoveChauhan-18 wants to merge 1 commit into
fossasia:masterfrom
LoveChauhan-18:patch-18
Open

Fix: Incorrect time response without place name (#241)#405
LoveChauhan-18 wants to merge 1 commit into
fossasia:masterfrom
LoveChauhan-18:patch-18

Conversation

@LoveChauhan-18
Copy link
Copy Markdown

@LoveChauhan-18 LoveChauhan-18 commented Feb 28, 2026

This PR fixes issue #241 where SUSI returned an incorrect default location time when no place name was specified.

Changes:

  • Added separate intent for queries without location
  • Added fallback response asking user to specify place
  • Ensured dynamic API call only runs when location is provided

Now:
• Queries with place return correct time
• Queries without place prompt user for clarification

Kindly review.

Summary by Sourcery

Handle time queries without an explicit location to avoid returning incorrect default times.

Bug Fixes:

  • Prevent incorrect default time responses when users ask for the time without specifying a place name.

Enhancements:

  • Introduce a dedicated intent and fallback response to prompt users for a location when handling time queries without a place.

…ck intent to prompt user for location instead of returning default time.
@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Feb 28, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the time intent handling so that time queries without an explicit location use a dedicated intent and fallback clarification response, while only triggering the dynamic API for time queries that include a place name.

File-Level Changes

Change Details Files
Split time intent handling between queries with a location and queries without one, adding a clarification fallback for location-less queries and guarding the external time API call behind a location check.
  • Introduce a dedicated intent pattern (or rule set) for time queries that do not include an explicit place name
  • Update existing time intent patterns to clearly distinguish queries that contain a location from those that do not
  • Add a fallback response that asks the user to specify a place when they request the time without providing a location
  • Ensure the dynamic time API call is only executed when the utterance matches an intent variant that includes a location entity
models/general/Utilities/en/time.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant