ci: do not start CLA jobs that exit immediately - #39
Conversation
The CLA script already returns at once for bots and for owners, members and collaborators, but only after the job has started. Hoisting the same test into a job-level condition means the job is never started at all. This repository is public, so Actions minutes are free and there is no saving here — the gain is that a pull request stops carrying a check that exists only to report that it had nothing to check. Behaviour is unchanged: the check still runs, for the external contributors it exists for, which on a public repository is the case that actually happens. Applied for consistency with the private repositories, where the same jobs were measured to cost real minutes for doing no work. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe CLA workflow now skips the ChangesCLA workflow gating
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The workflow gates the existing CLA job for documented exemptions while preserving checks for other contributors; no concrete merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
1 participant
What and why
The CLA script already returns at once for bots and for owners, members and collaborators — but only after the job has started. Hoisting the same test into a job-level
if:means the job is never started at all.This repository is public, so Actions minutes are free and there is no saving here. The gain is that a pull request stops carrying a check whose only outcome is to report that it had nothing to check.
Behaviour is unchanged. The check still runs for external contributors — which, on a public repository, is the case that actually happens.
Applied for consistency with the private repositories, where the same jobs were measured to cost real minutes for doing no work: over 1–14 September every CLA run there exited early, the authors being bots or the repository owner.
Verification
The file was re-parsed after editing and the job read back —
if:present,runs-onintact, steps unchanged. A YAML edit that silently drops a check looks exactly like a green build.Note that
cla.yamlruns onpull_request_target, so this pull request still runs the old version from the base branch. The change takes effect on the next pull request after merge.🤖 Generated with Claude Code
Summary by CodeRabbit