Repository navigation
packaging: get the version from the lsv distribution; declare coverage - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This fork installs as the
lsvdistribution. Three places askimportlib.metadatafor the version of theasvdistribution. When onlylsvis installed, that lookup raises an error andimport asvfails. The lightspeed commands also importcoverage, which is not a declared dependency. This PR asks for the version oflsvand addscoverageto the dependencies.Changes
lsv(asv/__init__.py,asv/commands/common_args.py,asv/commands/publish.py).Effect:
import asvandasv --versionwork when onlylsvis installed.Before:
importlib_metadata.PackageNotFoundError: No package metadata was found for asv.coverageis a dependency (pyproject.toml).Effect: a clean install can import the lightspeed commands.
Before:
KeyError: 'InitializeDiffcheck'from the plugin loader whencoveragewas missing.Verification
Clean Python 3.12 venv,
pip install -e ".[test]"of this branch:python -c "import asv": works, version0.1.dev2850+gfc16ba472;python -m asv --versionprints the same.pytest test/test_check.py test/test_util.py: 49 passed. Onmainthe same venv cannot importasv.Notes
asvinstalled (the task images) now show thelsvversion instead of the upstream one.