Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asv/contrib/lightspeed/survey.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def _add_extension_deps(
"""
# Collect packages that have extension modules, deduplicate scan dirs
seen_dirs: Set[str] = set()
for mod in sys.modules.values():
for mod in list(sys.modules.values()):
if mod is None:
continue
mod_file = getattr(mod, "__file__", None) or ""
Expand Down
15 changes: 15 additions & 0 deletions test/test_lightspeed_survey.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,18 @@ def time_child_import():
assert ok, reason
assert "child.py" in {p.split("/pkg/")[-1] for p in deps}
assert dict(os.environ) == env_before


def test_extension_scan_survives_import_during_scan(tmp_path, monkeypatch):
from types import ModuleType

from asv.contrib.lightspeed.survey import _add_extension_deps

class Lazy(ModuleType):
def __getattr__(self, name):
sys.modules.setdefault("lazy_loaded_child", ModuleType("lazy_loaded_child"))
raise AttributeError(name)

monkeypatch.setitem(sys.modules, "lazy_parent", Lazy("lazy_parent"))
monkeypatch.delitem(sys.modules, "lazy_loaded_child", raising=False)
_add_extension_deps({}, str(tmp_path))
Loading