Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Some image builds find 0 benchmarks because benchmark discovery stops with
RuntimeError: dictionary changed size during iteration. lsv#10 fixes this. This PR moves the template's pinned lsv commit to that fix.Changes
harbor_adapter/template/environment/Dockerfile:LSV_REFfrom9d1b667to9702a48(merge of lightspeed survey: copy sys.modules before the extension scan lsv#10).sys.modulesin_add_extension_deps.Between the two commits, lsv changes only this fix, its test, and GitHub Actions versions:
Verification
The new lsv test fails without the fix with the same error as the builds, and passes with it (see lsv#10). The failed builds: pandas-dev/pandas #23019, #23456, #23591, #23981, #24204, #24428, #24792, #25665.