Skip to content

task template: LSV_REF to the lsv fix for the sys.modules scan - #64

Open
ArjunS07 wants to merge 1 commit into
survey/phase1-template-20261008from
fix/lsv-ref-modules-snapshot
Open

ArjunS07 wants to merge 1 commit into
survey/phase1-template-20261008from
fix/lsv-ref-modules-snapshot

Conversation

@ArjunS07

Copy link
Copy Markdown
Contributor

Purpose

Some image builds find 0 benchmarks because benchmark discovery stops with RuntimeError: dictionary changed size during iteration. lsv#10 fixes this. This PR moves the template's pinned lsv commit to that fix.

Changes

Between the two commits, lsv changes only this fix, its test, and GitHub Actions versions:

$ git diff --stat 9d1b667 9702a48
 .github/workflows/build_wheels.yml |  6 +++---
 .github/workflows/ci.yml           |  2 +-
 .github/workflows/ci_win.yml       |  2 +-
 asv/contrib/lightspeed/survey.py   |  2 +-
 test/test_lightspeed_survey.py     | 15 +++++++++++++++

Verification

The new lsv test fails without the fix with the same error as the builds, and passes with it (see lsv#10). The failed builds: pandas-dev/pandas #23019, #23456, #23591, #23981, #24204, #24428, #24792, #25665.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant