Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The regression check stashes the agent's edits and reruns the selected tests at base.
git stashkeeps untracked files, so a test file the agent added stays in place. At base it imports code that does not exist, collection fails, and the base run gives no results. The check then counts as not run, and with no snapshot reference the trial is gradedunverified(-1.25).Seen on uxarray#1072: both Codex trials added a test file (
test/test_bounds.py,test/test_face_bounds.py), and both base runs returned no results.Changes
template/tests/pytest_runner.pyrun_base_and_diff: untrackedtest_*.py/*_test.pyfiles are passed to the base run as--ignore=<path>. Those tests do not exist at base, so they cannot be regressions.tests/docker/test_pytest_runner_regression.py:test_new_test_file_from_the_agent_is_left_out_of_the_base_run; fails without the change.Verification
tests/docker/test_pytest_runner_regression.py: 6 passed.Notes
Stacked on #57 (the runner deployed in the Phase 2 task copies).