Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
An agent patch that edits the measurement setup (benchmark files, ASV config,
conftest.py,.github/) was rejected as a whole, even when the rest of the patch was a real optimization. User decision (2026-10-09): the verifier discards those edits and measures with the task's own files.How it works
test.shcapturespatch.difffirst. It keeps the full agent diff./opt/fc_baseline_sha) and matches one of the protected patterns. The patterns are a copy ofPROTECTED_PATCH_PATTERNSinfcrl/grading/gates.py:git checkout <base> -- <path>;/logs/artifacts/protected_restore.json:{"ran": true, "base": "<sha>", "discarded": ["..."], "remaining": []}{"ran": false, "error": "<message>"}.conftest.pyfiles.The step does nothing without
/opt/fc_baseline_sha. Against the upstream commit, an untracked benchmark suite (for exampleastropy-benchmarks/) would count as "added" and be deleted.Changes
template/tests/test.shprotected_restore.jsonrecords themUsage
The grader in formulacode-verified-rl reads
protected_restore.json:ran: true,remainingemptydiscardedis kept as informationran: true,remainingnot emptyran: falseor no file (older tasks)Verification
In the astropy#14253 image, after the starting-tree commit from
setup.sh, with the agent's patch plus test edits (new.github/new.yml, modified rootconftest.py, newastropy/units/tests/conftest.py, deletedastropy-benchmarks/benchmarks/wcs.py, newbenchmarks/sp ace.py):discardedlists all 6 protected paths, andremainingis empty.astropy/units/quantity.py,astropy/units/tests/test_quantity.pyand the changelog entry.units.pyandconftest.pyhave the same md5 as the starting tree, andastropy-benchmarks/benchmarks/is complete (17 entries).{"ran": true, "discarded": [], "remaining": []}.tests/docker/test_template_skip_flags.pyandtest_pytest_runner_regression.py: 22 passed.Notes
fcrl/grading/gates.py. A change to one needs the same change to the other.