Repository navigation
Conversation
…mith when present verified-rl records now store the curriculum bucket in difficulty (with difficulty_source set) and the datasmith label in difficulty_datasmith. Prefer difficulty_datasmith; drop a curriculum difficulty so the record default applies. Old-schema rows render unchanged.
…ate' into fix/regen-difficulty-datasmith
…ate' into fix/regen-difficulty-datasmith
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
formula-code/formulacode-verified-rl#11 (merged) changes the meaning of
difficultyinrl_task_records.jsonl. Whendifficulty_sourceis set,difficultyis a curriculum bucket (very_hard,hard,balanced,easy), and the datasmith label (easy,medium,hard,unknown) moves todifficulty_datasmith. Without this PR,regen renderwrites the curriculum bucket intotask.tomlandtests/config.json. This PR makesregenkeep the datasmith label.How it works
flowchart TD A["records row"] --> B{"difficulty_datasmith set?"} B -- yes --> C["use difficulty_datasmith"] B -- no --> D{"difficulty_source set?"} D -- yes --> E["drop difficulty, so the record default applies"] D -- no --> F["use difficulty (old schema)"]Changes
record_from_configuses the datasmith label.difficulty_datasmithwhen the row has it.difficulty(withdifficulty_source), it drops that value, so the record default applies.difficulty = "balanced"(or another curriculum bucket) intotask.tomlandconfig.json.tests/docker/test_regen_difficulty.pyhas one parametrized test with 3 cases: an old schema row, a new schema row withdifficulty_datasmith, and a new schema row without it.Verification
These results are from when this PR was based on #30:
pytest -m "not slow" tests: 1682 passed, 10 skipped. The new tests are the difference from Make harbor_adapter the only FormulaCode task template (nested layout, baked image, baseline fingerprint, harbor imports it) #30.TileDB-Inc/TileDB-Py#1005, difficultyeasy) from verified-rl'srl_task_records.jsonlwas rendered with the old and the new code.task.tomlis identical byte for byte.render_stamp.json(timestamp and dirty flag).difficulty=balanced,difficulty_source=curriculum_spec,difficulty_datasmith=easy) and rendered.render_stamp.json.Notes
formulacode/canonical-task-templateis stale. This PR should be retargeted tomain.main, except oneparser.pynote that is in task template v1: the Phase 1 template and its fixes in one branch, for one merge into main #65.mainhas only the 2 files above.records.to_record(Supabasepull_requestsrows) does not change, because those rows never have the curriculum fields.