chore: pin the toolchain to 1.97.1 instead of floating on stable - #268
Merged
Conversation
`stable` is not a version -- it names whatever each host last downloaded. metis resolved it to 1.95.0 while CI installed 1.97.1, so two minor versions of new clippy lints sat between the compiler a change is checked with and the compiler that gates its merge. Under `-D warnings` such a lint is invisible locally and fatal in CI, and it presents as a broken local tool rather than a version gap. A floating pin is therefore worse than a stale fixed one: a stale pin is at least reproducible and legible, while `stable` diverges from itself across hosts and across time with nothing recording it. 1.97.1 matches kanon and typikon and is the current stable. No workflow passes an explicit `toolchain:` to a gate job, so this file is what they honour. The one `nightly` in the repo is `codeql.yml`'s `rust_toolchain` input to the shared analyzer, which is unaffected by this file and stays as it is. Refs forkwright/kanon#3336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
rust-toolchain.toml:channel = "stable"→channel = "1.97.1".Why
stableis not a pinIt names whatever each host last downloaded, so it is a different compiler per machine and drifts on its own with no commit. Measured on metis:
So a local check compiles with 1.95.0 while CI installs
stablefresh and gets 1.97.1 — two minor versions of new clippy lints between the compiler a change is verified with and the compiler that gates its merge. Under-D warningssuch a lint is invisible locally and fatal in CI, and it presents as a broken local tool rather than a version gap.A floating pin is worse than a stale fixed one. A repo on an old fixed version is at least reproducible and its divergence is legible;
stablediverges from itself across hosts and across time with nothing recording it.Why 1.97.1
It is the current stable and the pin kanon and typikon already use, so this converges rather than adding a ninth fleet toolchain. Fleet context: forkwright/kanon#3336.
Scope
One line plus its rationale comment. No workflow passes an explicit
toolchain:to a gate job here, so this file is already what they honour — nothing else needs changing. The singlenightlyin the repo iscodeql.yml'srust_toolchaininput to the shared analyzer; it does not read this file and is untouched.Expected fallout
Possibly none, possibly a handful of new lints from 1.96/1.97 arriving at once. CI is the judge — that is the point of the change, and any lints it surfaces are ones that were already going to fire, just at an unpredictable moment instead of this one.
Refs forkwright/kanon#3336