chore(toolchain): align rust-toolchain.toml to fleet 1.97.1 - #96
Merged
Conversation
added 2 commits
August 15, 2026 22:34
Refs forkwright/kanon#3489.
The 1.88 -> 1.97.1 toolchain bump denies clippy::map_unwrap_or under -D warnings. Result::is_ok_and expresses the same thing directly and does not allocate an intermediate Result<bool>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Aligns
rust-toolchain.tomlfrom1.88to1.97.1— the fleet's control-plane value (kanonpins the same, and
kanonis the repo whose lint behaviour every other repo's gate inherits).Matches kanon's file shape exactly:
channel+components = ["rustfmt", "clippy"].Also fixes a comment in
.github/workflows/gate-attestation.ymlthat hardcoded the old1.88value in prose — left uncorrected it would have been a stale restatement the moment this PR
merged.
Why (forkwright/kanon#3489)
Measured across fifteen fleet repos: five distinct toolchain values plus four repos with no pin
at all. A repo pinned at
1.85and one floating onstabledo not compile the same language — alint stabilised after 1.85 fires in one and is inert in the other, so green does not transfer
between repos.
#3489tracks the systemic fix (aREPO-SETUP.mdrule +kanon lintenforcementRefs forkwright/kanon#3489 — does not close it. The issue's
Done when:is unmet by this PRon purpose:
REPO-SETUP.mdstates the toolchain-channel fact — not done here, out of scope for aper-repo bump; belongs in kanon.
kanon lintfails a repo that disagrees — not done here, same reason.1.97.1,matching kanon's. The other thirteen rows are unchanged by this PR.
Verification
Gated on verda-build (
kanon gate --tier full --stamp, 1.97.1 toolchain) — this box's stable isolder than the target (1.94), so validation could not happen locally.
REAL_EXIT=<N>, tail below.Fallout from the bump
<TO FILL: exact new/stabilised lints surfaced, real-defect vs lint-preference call for each>
Negative fixture
<TO FILL: per agent-brief.md — either name one, or state explicitly this change adds no check>
No AI attribution
Commit and PR carry none.