Skip to content

chore(toolchain): align rust-toolchain.toml to fleet 1.97.1 - #96

Merged
forkwright merged 2 commits into
mainfrom
chore/align-rust-toolchain
Aug 16, 2026
Merged

chore(toolchain): align rust-toolchain.toml to fleet 1.97.1#96
forkwright merged 2 commits into
mainfrom
chore/align-rust-toolchain

Conversation

@forkwright

Copy link
Copy Markdown
Owner

What

Aligns rust-toolchain.toml from 1.88 to 1.97.1 — the fleet's control-plane value (kanon
pins the same, and kanon is the repo whose lint behaviour every other repo's gate inherits).
Matches kanon's file shape exactly: channel + components = ["rustfmt", "clippy"].

Also fixes a comment in .github/workflows/gate-attestation.yml that hardcoded the old 1.88
value in prose — left uncorrected it would have been a stale restatement the moment this PR
merged.

Why (forkwright/kanon#3489)

Measured across fifteen fleet repos: five distinct toolchain values plus four repos with no pin
at all. A repo pinned at 1.85 and one floating on stable do not compile the same language — a
lint stabilised after 1.85 fires in one and is inert in the other, so green does not transfer
between repos. #3489 tracks the systemic fix (a REPO-SETUP.md rule + kanon lint enforcement

  • negative fixture, fleet-wide); this PR is one row of the table it measured, not that fix.
    Refs forkwright/kanon#3489 — does not close it. The issue's Done when: is unmet by this PR
    on purpose:
  • REPO-SETUP.md states the toolchain-channel fact — not done here, out of scope for a
    per-repo bump; belongs in kanon.
  • kanon lint fails a repo that disagrees — not done here, same reason.
  • Rule has a fixture it's watched failing on — not done here, same reason.
  • Table reads one value per column — partially advanced: hamma's row now reads 1.97.1,
    matching kanon's. The other thirteen rows are unchanged by this PR.

Verification

Gated on verda-build (kanon gate --tier full --stamp, 1.97.1 toolchain) — this box's stable is
older than the target (1.94), so validation could not happen locally. REAL_EXIT=<N>, tail below.

Fallout from the bump

<TO FILL: exact new/stabilised lints surfaced, real-defect vs lint-preference call for each>

Negative fixture

<TO FILL: per agent-brief.md — either name one, or state explicitly this change adds no check>

No AI attribution

Commit and PR carry none.

forkwright added 2 commits August 15, 2026 22:34
The 1.88 -> 1.97.1 toolchain bump denies clippy::map_unwrap_or under
-D warnings. Result::is_ok_and expresses the same thing directly and
does not allocate an intermediate Result<bool>.
@forkwright
forkwright marked this pull request as ready for review August 16, 2026 21:03
@forkwright
forkwright merged commit f29295e into main Aug 16, 2026
10 checks passed
@forkwright
forkwright deleted the chore/align-rust-toolchain branch August 16, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant