fix(gate-attestation): pin hybrid-gate.yml call to a SHA, closing the lint-debt gap - #91
Merged
Merged
Conversation
added 2 commits
August 15, 2026 15:19
RUST/pub-visibility:crates/dictyon/src/control.rs and .../noise.rs stopped matching once both modules split into control/mod.rs and noise/mod.rs, the same split wire.rs already uses (whose own ignore entry is already a glob). The stale entries matched no file and silently suppressed nothing; kanon lint warned about both on every run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
kanon lintcarried one live violation onmain:SHELL/unpinned-actionon.github/workflows/gate-attestation.yml:88— the reusable-workflow call toforkwright/.github/.github/workflows/hybrid-gate.ymlused a mutable@mainref instead of a pinned commit SHA. The gate fails on any warning by default,
so this alone blocked
kanon gate --stampfor every PR.Re-verified premise, corrected
The literal 12-entry
.kanon-lint-baseline.tomlthis issue was filed against(
remove_after = "2026-08-13") no longer exists onmain— PR #86 (merged2026-08-09) already resolved every one of those entries plus 7 unbaselined
findings and deleted the baseline file.
kanon lint .against a freshorigin/maincheckout confirms this: none of the original rule families(
RUST/file-too-long,RUST/indexing-slicing,NAMING/no-owner-prefix,RUST/no-silent-result-swallow,RUST/no-debug-derive-on-public-types,COMMENTS/deflection-without-tracking,RUST/primitive-for-domain-id,RUST/non-exhaustive-enum,RUST/config-deny-unknown-fields) fire anymore.crates/hamma-coreiscrates/mitosnow, so the specificNAMING/no-owner-prefixentry this issue's follow-up note asked about isalready gone with it — nothing left to carry forward in a new baseline.
What #86 did not catch was
SHELL/unpinned-actionon the reusable-workflowcall itself, which is the one violation still blocking the gate today. This
PR closes that gap so #57's actual acceptance criterion —
kanon lint .clean on main — is met, with no baseline file needed at all.
What changed
SHELL/unpinned-action: pinforkwright/.github/.github/workflows/hybrid-gate.ymlto its current
mainSHA (df92942bcc41cc7ffd0339b75b2f01e52269d0ef),matching the convention already used by
typikonandthumos(SHA + atrailing
# maincomment, plus a WHY comment documenting the refreshcommand).
.kanon-lint-ignorestill carriedRUST/pub-visibility:crates/dictyon/src/control.rsand.../noise.rsfrombefore both modules split into
control/mod.rs/noise/mod.rs(the samesplit
wire.rsalready went through, whose ignore entry is already aglob). The stale entries matched no file and silently suppressed nothing;
kanon lintwarned about both on every run. Re-globbed to match thecurrent layout.
Verification
--tier nobuildis the local-verifiable slice (zero rustc invocations, perthis box's compile-on-CI-only posture);
cargo build/clippy/nextest run onthis PR's GitHub Actions checks, which is what actually gates merge.
No Rust source changed — YAML and
.kanon-lint-ignoreonly.Closes #57