fix(poiesis-printer-chromium): align which to 8, matching the rest of the workspace - #6964
Merged
Conversation
… the workspace printer-chromium pinned `which = "=7.0.3"` while organon and poiesis/doc already depended on `which = "8"`, splitting the workspace across two majors of the same crate and duplicating it (plus its which-7-only transitive dep env_home) in Cargo.lock. git blame traces the exact pin to the crate's initial commit (bd4e29e, "add chromium CDP printer for HTML-to-PDF conversion"), introduced on the same line-style as `chromiumoxide = "=0.7.0"`. Neither the commit message nor any nearby comment gives a reason specific to `which` (no RUSTSEC ignore, no deny.toml/audit.toml entry references it) -- the exactness reads as inherited from chromiumoxide's own pin rather than a deliberate constraint on which itself. With no recorded reason to keep it exact, move to the unpinned "8" that already matches organon and poiesis/doc. which::which()'s signature is unchanged across the bump: printer-chromium's only call site is byte-identical in shape to organon's existing which-8 call site, and `cargo check -p poiesis-printer-chromium --features chromium` resolves which 8.0.5 clean with no warnings.
|
forkwright
pushed a commit
that referenced
this pull request
Aug 25, 2026
🤖 I have created a release *beep* *boop* --- ## [0.42.1](v0.42.0...v0.42.1) (2026-08-25) ### Bug Fixes * **poiesis-printer-chromium:** align which to 8, matching the rest of the workspace ([#6964](#6964)) ([f061463](f061463)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
crates/poiesis/printer-chromium/Cargo.tomlpinnedwhich = "=7.0.3"whilecrates/organon/Cargo.tomlandcrates/poiesis/doc/Cargo.tomlalready carriedwhich = "8"-- the same workspace resolving two majors of the same crate. Moved printer-chromium towhich = "8".Why exact, and why removing it is safe
Traced the pin to its origin: commit
bd4e29e3b("add chromium CDP printer for HTML-to-PDF conversion"), which introduced it on the same line-style aschromiumoxide = "=0.7.0"in the same diff. Neither the commit message nor any comment near the line gives a reason specific towhich-- no RUSTSEC ignore references it, nodeny.toml/audit.tomlentry mentions it. Reads as inherited from chromiumoxide's own exact-pin convention rather than a deliberate constraint onwhich. With no recorded rationale, matching the rest of the workspace (organon, poiesis/doc) is the right call.API breakage
None. printer-chromium's only
whichcall site (which::which(candidate)inchromium_impl.rs, used for Chromium binary discovery) is byte-identical in shape to organon's existing which-8 call site, which already compiles clean.Verified
cargo check -p poiesis-printer-chromium --features chromium(isolatedCARGO_TARGET_DIR) ->Finished, exit 0, resolveswhich v8.0.5.Cargo.lockdiff: singlewhichentry at 8.0.5, all four dependents point at it, duplicatewhich 7.0.3entry and its orphaned which-7-only transitive depenv_homeare gone.poiesis/docconfirmed already onwhich = "8"before this change -- printer-chromium was the sole outlier.Not run: full workspace build/test (out of scope for a single-crate dependency bump on a shared box; scoped
cargo checkis the appropriate verification per the box's build constraints).