chore(deps): bump compact_str 0.9 -> 0.10 - #6963
Merged
Merged
Conversation
harmonia and thumos already declare compact_str 0.10 with the same features = ["serde"]; aletheia was the last fleet repo on 0.9. No breaking API changes between 0.9.x and 0.10.0 per the crate's changelog (MSRV moved 1.60 -> 1.71, well below aletheia's pinned 1.97.1 toolchain; the release is mostly perf work and UB fixes in retain()/as_mut_bytes()/from_utf8_lossy, none of which aletheia's CompactString::from/new call sites touch). cargo check on the two crates that use CompactString directly (energeia, krites) passes clean. tokenizers (via episteme) still pins compact_str ^0.9 transitively; Cargo now resolves two independent versions in the lockfile, which is expected and not a conflict.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
compact_strfrom0.9to0.10in the rootCargo.tomlworkspace dependency table.Cargo.lockupdates accordingly.Why
Fleet alignment: harmonia and thumos both already declare
compact_str = { version = "0.10", features = ["serde"] }. aletheia was the only fleet repo still on 0.9.Compatibility check
Read the crate's changelog for the 0.9.x -> 0.10.0 gap: no explicit breaking API changes are listed. The notable items are an MSRV bump (1.60 -> 1.71 — aletheia pins rustc 1.97.1, no issue), new optional integrations with other crates (garde/schemars/valuable/pyo3/defmt/bevy-reflect/utoipa — none enabled here), perf work, and UB fixes in
retain(),as_mut_bytes(), andfrom_utf8_lossy.Grepped every
CompactString/compact_struse site in the repo (crates/energeia, crates/krites — the only two crates that import it directly). All usage isCompactString::from(...),CompactString::new(...), andInto<CompactString>trait bounds. None of the sites useretain(),as_mut_bytes(), orfrom_utf8_lossy()on aCompactString, so the bugfix-affected surface isn't touched.Verification
cargo check -p energeia -p krites(scopedCARGO_TARGET_DIR, own worktree) — exit 0, clean, no new warnings.Cargo.locknow carries twocompact_strentries:0.10.0for the workspace's own dependency, and0.9.1still pinned fortokenizers(a transitive dependency ofepisteme, which requirescompact_str = "^0.9"and wasn't part of this change). Both resolve independently — no conflict, and this is the expected state for a 0.x crate with two independent requirement ranges in the graph.Not verified
Did not run the crate's own test suite (workspace
cargo testis out of scope per worktree constraints) — onlycargo checkon the two consuming crates. No behavioral/runtime testing beyond compile-time checking.