chore(deps): move the theatron pins to v1.6.2 - #6962
Merged
Conversation
theatron is our own repository and these pins sat two tags behind it. v1.6.1 and v1.6.2 are both fix releases: parodos hyperlink probes isolated from the environment, keryx SSE and bathron corrections, dead forge links repointed at GitHub, and the toolchain moved from nightly to stable. Bumped in both workspaces, because they are two. The root workspace and crates/theatron/proskenion carry independent lockfiles and independent declarations, and scripts/check-proskenion-pins.py fails when their pins differ in tag, features, or default-features. Bumping one is a broken tree, not a partial improvement. The `version = "1.5.0"` resolution hints are deliberately untouched. They exist so cargo-deny can resolve the git dep in the graph, they are a floor rather than an assertion of the version in use, and theatron 1.6.2 satisfies them. Their resolved sets differ and that is not a mistake: the root workspace resolves parodos, themelion, gramma, bathron and keryx; proskenion resolves skeue in place of parodos. Verified after the change that both graphs still resolve under --locked and that the pin-parity guard passes.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



theatron is our own repository and these pins sat two tags behind it —
v1.6.0against a releasedv1.6.2.What is in the gap
Both are fix releases:
Code changes are confined to
bathron/src/lib.rs,keryx/src/sse.rsandparodos/src/hyperlink.rs, plus test isolation. No API surface moved.Bumped in both workspaces, because there are two
The root workspace and
crates/theatron/proskenioncarry independent lockfiles and independent declarations — six pin sites in the root manifest, five in proskenion.scripts/check-proskenion-pins.pyfails when the two disagree on tag, features, ordefault-features, so bumping one is a broken tree rather than a partial improvement.Their resolved sets legitimately differ, which is worth knowing before reading the lock diff: the root resolves
parodos, themelion, gramma, bathron, keryx; proskenion resolvesskeuein place ofparodos. Neither lock carries the other's crate.What is deliberately untouched
The
version = "1.5.0"fields. They exist socargo-denycan resolve the git dependency in the graph — the manifest comment says so — and they are a floor, not a claim about the version in use. theatron 1.6.2 satisfies^1.5.0, so tightening them would add churn on every future bump and buy nothing.Verification, before pushing
scripts/check-proskenion-pins.py→ proskenion theatron pins match root workspacecargo metadata --lockedresolves in both graphsv1.6.0string remains in any of the four filesNoticed, not fixed here
skeueis declared in the root workspace dependencies but does not appear in the rootCargo.lock— nothing in that workspace consumes it. It is real and used in proskenion. That is an unused declaration rather than a pin problem, and it is not this PR's business.