merge: development -> main#6
Merged
Merged
Conversation
… harness, sync helper
…ists to _common.sh
![charliecreates[bot]](https://avatars.githubusercontent.com/in/1140780?s=60&v=4){kind=small}
There was a problem hiding this comment.
Blocking feedback
- Empty
CGW_TYPECHECK_CHECK_ARGSgets coerced tocheck, so pyright projects runpyright check(invalid) and always produce a false typecheck warning — scripts/git/_common.sh#L890
If you want me to push a fix, reply with item numbers (for example: please fix 1).
| run_tool_with_logging "TYPECHECK" "${logfile}" "${tc_bin}" ${stripped_args} "$@" | ||
| else | ||
| # shellcheck disable=SC2086 # Word splitting intentional: CGW_TYPECHECK_CHECK_ARGS/CGW_TYPECHECK_EXCLUDES contain multiple flags | ||
| run_tool_with_logging "TYPECHECK" "${logfile}" "${tc_bin}" ${CGW_TYPECHECK_CHECK_ARGS:-check} ${CGW_TYPECHECK_EXCLUDES:-} |
There was a problem hiding this comment.
CGW_TYPECHECK_CHECK_ARGS is intentionally set to an empty string for pyright in configure.sh, but this call uses ${CGW_TYPECHECK_CHECK_ARGS:-check}. The :- operator treats empty as unset, so pyright ends up running as pyright check, which is not a valid invocation. In practice this makes pyright-based projects show a non-blocking warning on every commit even when types are clean.
Suggested fix: preserve intentionally-empty args and only default when the variable is truly unset (for example ${CGW_TYPECHECK_CHECK_ARGS-check}), and apply the same change in the file-list branch above.
… global gitignore
…efault} not ${var:-default})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Branch
development->main