fix(desktop): stop calling a cancelled share a Screen Recording problem - #193
Merged
Merged
Conversation
Electron answers a refused display request with "Invalid capture constraints" whatever the reason, so closing the "Choose what to share" menu showed the Mac permission steps to somebody who could share fine. The page now asks the desktop app for macOS's Screen Recording status and only gives that advice when it is not granted. Claude-Session: https://claude.ai/code/session_01CG4pPCsd8pdySNvBpt8fTk
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner saw "Your computer did not allow screen sharing…" on the Mac desktop app while sharing worked.
Electron 44's
DisplayMediaDeviceChosenanswerscallback()with nothing asINVALID_DISPLAY_CAPTURE_CONSTRAINTS, the same error a missing Screen Recording permission produces. The app refuses that way whenever the person cancels or dismisses the "Choose what to share" menu, so every cancel showed the permission advice.desktop:screen-accessIPC (trusted sender only) returnssystemPreferences.getMediaAccessStatus('screen')on macOS,grantedelsewhere.showShareErrorasks it before showing the advice; with access granted a refusal was the person and nothing is shown.Test:
portrait-share.specgains a case with a stand-in desktop bridge (granted: no advice; denied: advice). Not yet tried in the packaged Mac app.🤖 Generated with Claude Code
https://claude.ai/code/session_01CG4pPCsd8pdySNvBpt8fTk