feat(call): keep you in the middle of your own picture - #192
Merged
Merged
Conversation
With a background effect on, the pipeline now crops the finished frame around the person the effect's mask finds, eased so it drifts rather than twitches and zoomed no more than 1.6x. It crops pixels the effect has already painted, so it can only send less of the room. With no mask to go on it eases back to the whole frame. "Keep me in the middle of the picture" in the effects panel turns it off; it is on by default and remembered per device. Claude-Session: https://claude.ai/code/session_01CG4pPCsd8pdySNvBpt8fTk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The owner's self-view cut their face at the edge of the picture; they asked for the video to focus on them.
app/src/auto-frame.ts: person box from the effect's mask (trimmed, sampled), crop that centres it with headroom, eased with a dead band, max 1.6x zoom, holds 30 frames through a missing mask then eases out.CameraPipeline: the effect paints a private stage canvas; the published canvas is a crop of it. Nothing from the raw camera reaches the published canvas by any new path.VideoEffect.personMask: the mask, only when the last frame was a composite.Tests: unit tests for the framing;
effects.spec,call-prefs.spec,camera-effects-no-phone-home.specpass. Not yet seen with a real face and camera. Android has no effects, so no framing there.🤖 Generated with Claude Code
https://claude.ai/code/session_01CG4pPCsd8pdySNvBpt8fTk