fix(desktop): keep the area frame clickable on Windows and make Move reliable - #191
Merged
Merged
Conversation
…reliable Once the pointer crossed the drawing hole the frame went click-through and only the renderer's forwarded mouse moves took it back. Windows does not deliver those reliably, so Move, the corners and Cancel all stopped answering and the app had to be killed. Watch the cursor from the main process on every platform, as Linux already did. Move used a native drag region, which is dead on Windows after the frame has been click-through and fiddly on macOS. The bar now moves the frame from the main process after the real cursor position. Claude-Session: https://claude.ai/code/session_01CG4pPCsd8pdySNvBpt8fTk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Windows tester could not move, resize or close an area share and had to kill the app; Move is also unreliable on macOS.
Local desktop e2e: the drag step passes.
call.spec.tsstill fails at "Composer and Leave call must fit 1024x700" on main as well, independent of this change. Not verified on real Windows.🤖 Generated with Claude Code
https://claude.ai/code/session_01CG4pPCsd8pdySNvBpt8fTk