fix: stop a full-screen share mirroring itself into the picture - #189
Merged
Merged
Conversation
An area sized to the whole display, or a plain full-screen share, captures this device's own on-screen surfaces that show the outgoing picture too - the local preview tile and the floating marks window - so the tile shows the capture, which shows the tile, without end. Reported from a real call on Linux X11, where window exclusion from capture is unavailable. Withhold the live picture from both surfaces whenever the capture covers (near enough) the whole display, leaving a placeholder notice in its place. The marks overlay on each paints on its own canvas rather than a copy of the video, so drawing on a full-screen share still reaches and shows for the sharer.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a real call: a Linux desktop sharing an area sized to the whole screen sent an endless screen within a screen, because the sharer's own live preview of the share (the local preview tile, and the floating preview window) sat inside the captured display.
displaySurface === 'monitor'), the sharer's own live preview is withheld and a short notice shown instead. The marks overlay is untouched, so the viewer's drawings still show on the sharer's screen.screen-share-audio.spec.tsthat fails without the wiring. Share specs 12/12 locally on chromium; unit suite 2626/2626.Not verified on a real X11 desktop.
🤖 Generated with Claude Code
https://claude.ai/code/session_01CG4pPCsd8pdySNvBpt8fTk