fix(call): an unmute on a paired device keeps the microphone - #188
Merged
Merged
Conversation
Arbitrate singular roles on this device's current claims rather than the relay's echo of them, so the render between publish and echo no longer mutes the microphone just unmuted. Stamp a mic take past every claim seen, so a paired phone with a fast clock cannot keep winning.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From a real call with two people each on Android and a desktop (Mac, Linux): audio stopped and pressing unmute did nothing; leaving and rejoining did not help.
RoomSession.participants()arbitrated the mic and monitor roles on the relay's echo of this device's own entry. Between publishing a claim and its echo,renderCallMediasaw the other device still holding the mic and switched off the track just unmuted; the echo then made this device the holder, muted. Roles are now resolved on this device's current claims.nextRoleClaim, past every claim seen, so a paired phone whose clock runs ahead cannot keep winning.🤖 Generated with Claude Code
https://claude.ai/code/session_01CG4pPCsd8pdySNvBpt8fTk