fix: increment retry_count when prepare_workspace fails#196
Open
danchild wants to merge 2 commits into
Open
Conversation
The prepare_workspace exception handler set last_error but never incremented retry_count, so the routing function's retry_count >= max_retries check never triggered — causing an unbounded retry loop. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
3 tasks
Adds a test that starts with retry_count=1 and asserts it becomes 2 after a prepare_workspace failure, ensuring the routing function can break the loop after max_retries. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178
Summary
prepare_workspace()exception handler inimplement_tasksetlast_errorbut never incrementedretry_countretry_count >= max_retries(3) to escalate, but sinceretry_countstayed at 0, the loop never brokeretry_countincrement to match the pattern used by other exception handlers in the same fileTest plan
tests/unit/workflow/nodes/test_implementation.py— 12/12)🤖 Generated with Claude Code