Skip to content

test: cover webhook queue boundaries#188

Merged
eshulman2 merged 1 commit into
forge-sdlc:mainfrom
eshulman2:test/webhook-queue-boundaries
Jul 20, 2026
Merged

test: cover webhook queue boundaries#188
eshulman2 merged 1 commit into
forge-sdlc:mainfrom
eshulman2:test/webhook-queue-boundaries

Conversation

@eshulman2

Copy link
Copy Markdown
Collaborator

Summary

  • atomically deduplicate delivery IDs and append webhook messages to Redis Streams
  • wire Jira and GitHub webhook routes to report duplicate deliveries without requeueing
  • add real FastAPI-to-Redis integration scenarios for accepted, duplicate, invalid-signature, and malformed deliveries
  • add focused unit coverage for the atomic producer behavior

Why

Webhook deduplication utilities existed but were not connected to either route or the queue consumer, so repeated Jira or GitHub deliveries created duplicate stream messages. The Redis script makes delivery reservation and stream publication one atomic operation.

Verification

  • 30 webhook route and queue producer unit tests passed
  • 12 real-Redis webhook/queue integration tests passed
  • full source Ruff lint and formatting checks passed

The local Python 3.14 environment stalled during the broader async fast suite; the required CI gate runs the supported Python 3.11 environment.

@eshulman2
eshulman2 merged commit ca59a51 into forge-sdlc:main Jul 20, 2026
6 checks passed
@eshulman2
eshulman2 deleted the test/webhook-queue-boundaries branch July 20, 2026 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant