Conversation
There was a problem hiding this comment.
Pull request overview
Updates Decimo’s Mojo toolchain and build/test workflows to target Mojo v1.0.0b2, including the switch from .mojopkg packaging to .mojoc precompiled artifacts used across CI, scripts, and Pixi tasks.
Changes:
- Bump Pixi dependencies to
mojo >=1.0.0b2,<2andargmojo >=0.7,<0.8, updating the lockfile accordingly. - Migrate build/test/documentation flows from
mojo package/decimo.mojopkgtomojo precompile/decimo.mojoc(Pixi tasks, CI workflow, helper scripts). - Minor documentation/docstring adjustments and a Decimal128 string-slice construction update to use
Spanwithunsafe_from_utf8.
Reviewed changes
Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test.sh |
Switch test preflight build from .mojopkg to .mojoc via mojo precompile. |
tests/test_cli.sh |
Update CLI test preflight to ensure tests/decimo.mojoc exists. |
tests/bigint/test_bigint_special.mojo |
Docstring wording/format tweaks in BigInt special tests. |
src/decimo/decimal128/decimal128.mojo |
Update StringSlice construction to use Span with unsafe_from_utf8. |
src/decimo/bigint/special.mojo |
Add docstrings for comptime constants used in factorial/product_range logic. |
src/decimo/bigdecimal/special.mojo |
Add docstrings for comptime constants; clarify product_range docstring raises section. |
pixi.toml |
Bump dependencies and migrate tasks from mojo package to mojo precompile with .mojoc artifacts. |
pixi.lock |
Refresh lockfile for updated mojo/argmojo/mblack versions. |
examples/run_bigfloat.sh |
Update helper script to build/load tests/decimo.mojoc. |
.gitignore |
Ignore .mojoc artifacts in addition to .mojopkg. |
.github/workflows/run_tests.yaml |
Update CI to build/stage/upload .mojoc artifacts and use mojo precompile. |
.github/actions/setup-decimo/action.yml |
Update composite action to download/stage the .mojoc artifact. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates Decimo’s Mojo toolchain and build/test workflows to target Mojo
v1.0.0b2, including the switch from.mojopkgpackaging to.mojocprecompiled artifacts used across CI, scripts, and Pixi tasks.