Skip to content

Putting back SalesforceSDKCommon#4029

Merged
sfdctaka merged 1 commit intoforcedotcom:devfrom
sfdctaka:sdkcommonspec
May 5, 2026
Merged

Putting back SalesforceSDKCommon#4029
sfdctaka merged 1 commit intoforcedotcom:devfrom
sfdctaka:sdkcommonspec

Conversation

@sfdctaka
Copy link
Copy Markdown
Contributor

@sfdctaka sfdctaka commented May 5, 2026

No description provided.

@sfdctaka sfdctaka requested a review from bbirman May 5, 2026 19:31
Copy link
Copy Markdown
Member

@bbirman bbirman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing!

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

TestsPassed ✅SkippedFailed
SalesforceSDKCore iOS ^18 Test Results625 ran625 ✅
TestResult
No test annotations available

@codecov
Copy link
Copy Markdown

codecov Bot commented May 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 66.40%. Comparing base (5bef69b) to head (fa5771d).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4029      +/-   ##
==========================================
- Coverage   70.39%   66.40%   -4.00%     
==========================================
  Files         245      245              
  Lines       21449    21449              
==========================================
- Hits        15100    14244     -856     
- Misses       6349     7205     +856     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 70.69% <ø> (-0.19%) ⬇️
Core 58.87% <ø> (-6.19%) ⬇️
SmartStore 73.44% <ø> (ø)
MobileSync 88.79% <ø> (ø)
see 33 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

TestsPassedSkippedFailed ❌️
AuthFlowTester UI Test Results all1 ran1 ❌
TestResult
AuthFlowTester UI Test Results all
AuthFlowTesterUITests.xctest
LegacyLoginTests.testCAOpaque_DefaultScopes_WebServerFlow()❌ failure

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results625 ran624 ✅1 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
testMissingLoginHint()❌ failure

@sfdctaka sfdctaka merged commit 3cdaf5f into forcedotcom:dev May 5, 2026
24 of 30 checks passed
@sfdctaka sfdctaka deleted the sdkcommonspec branch May 5, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants