Add public API to trigger Login for Admin flow.#4026
Merged
brandonpage merged 2 commits intoforcedotcom:devfrom May 5, 2026
Merged
Add public API to trigger Login for Admin flow.#4026brandonpage merged 2 commits intoforcedotcom:devfrom
brandonpage merged 2 commits intoforcedotcom:devfrom
Conversation
Clang Static Analysis Issues
Generated by 🚫 Danger |
|
||||||||||||||||
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4026 +/- ##
==========================================
+ Coverage 65.64% 66.48% +0.83%
==========================================
Files 245 245
Lines 21449 21449
==========================================
+ Hits 14081 14261 +180
+ Misses 7368 7188 -180
🚀 New features to boost your workflow:
|
|
||||||||||||||
|
||||||||||||||||||
wmathurin
reviewed
May 1, 2026
| @param loginViewController The login view controller whose scene's active auth session should | ||
| switch to "Login for Admin". Its window's scene is used to locate the session. | ||
| */ | ||
| - (void)loginViewControllerDidSelectLoginForAdmin:(SFLoginViewController *)loginViewController NS_SWIFT_NAME(loginViewControllerDidSelectLoginForAdmin(_:)) SFSDK_DEPRECATED(13.2.1, 14.0, "Will be removed in 14.0 when a permanent solution if provided."); |
Contributor
There was a problem hiding this comment.
Typo: "when a permanent solution if provided" should be "when a permanent solution is provided"
wmathurin
approved these changes
May 2, 2026
bbirman
reviewed
May 2, 2026
| @param loginViewController The login view controller whose scene's active auth session should | ||
| switch to "Login for Admin". Its window's scene is used to locate the session. | ||
| */ | ||
| - (void)loginViewControllerDidSelectLoginForAdmin:(SFLoginViewController *)loginViewController NS_SWIFT_NAME(loginViewControllerDidSelectLoginForAdmin(_:)) SFSDK_DEPRECATED(13.2.1, 14.0, "Will be removed in 14.0 when a permanent solution if provided."); |
Member
There was a problem hiding this comment.
Where would the app get the reference to the login view controller from? the window?
Contributor
Author
There was a problem hiding this comment.
@bbirman Good callout. As I see it they have two options:
- Retain a reference from
UserAccountManager.shared.loginViewControllerConfig.loginViewControllerCreationBlock. - Walk the view hierarchy.
I assume option 1 is preferred? Should I add that to the comment?
Member
There was a problem hiding this comment.
Were you able to test with option 1? I think the reference would be to the block, not the view controller created by the block?
Otherwise I was wondering if option 2 could use SFSDKWindowManager's authWindow's topViewController, or if there's a way to get around the app providing the reference, but do we know if anyone is hiding the settings icon? Might not be worth it to invest more if not
Contributor
Author
There was a problem hiding this comment.
I was thinking something like this:
UserAccountManager.shared.loginViewControllerConfig.loginViewControllerCreationBlock = { [weak self] in
let vc = SalesforceLoginViewController()
self?.currentLoginVC = vc // retain weakly for later
return vc
}
Member
There was a problem hiding this comment.
ah gotchya! no preference for me, whatever you think looks cleanest
bbirman
approved these changes
May 4, 2026
brandonpage
added a commit
that referenced
this pull request
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.