Skip to content

Cherry Pick Login for Admin feature.#4024

Merged
brandonpage merged 1 commit intoforcedotcom:masterfrom
brandonpage:cherry-pick/login-for-admin
Apr 24, 2026
Merged

Cherry Pick Login for Admin feature.#4024
brandonpage merged 1 commit intoforcedotcom:masterfrom
brandonpage:cherry-pick/login-for-admin

Conversation

@brandonpage
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

1 Error
🚫 Please re-submit this PR to the dev branch, we may have already fixed your issue.

Generated by 🚫 Danger

@github-actions
Copy link
Copy Markdown

1 Warning
⚠️ Static Analysis found an issue with one or more files you modified. Please fix the issue(s).

Clang Static Analysis Issues

File Type Category Description Line Col
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 120 19
SFOAuthCoordinator Nullability Memory error nil assigned to a pointer which is expected to have non-null value 244 15
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1579 15
SFUserAccountManager Nullability Memory error Null passed to a callee that requires a non-null 2nd parameter 1594 15
SFUserAccountManager Nullability Memory error nil passed to a callee that requires a non-null 2nd parameter 2229 13

Generated by 🚫 Danger

@github-actions
Copy link
Copy Markdown

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^26 Test Results626 ran624 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^26 Test Results
SFSDKAuthConfigUtilTests.testBrowserBasedLoginEnabled❌ failure
SalesforceRestAPITests.testCreateQuerySearchDelete❌ failure

@github-actions
Copy link
Copy Markdown

TestsPassed ☑️SkippedFailed ❌️
SalesforceSDKCore iOS ^18 Test Results626 ran624 ✅2 ❌
TestResult
SalesforceSDKCore iOS ^18 Test Results
testNonCallbackURL()❌ failure
SFSDKAuthConfigUtilTests.testBrowserBasedLoginEnabled❌ failure

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 24, 2026

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.21%. Comparing base (fe97c22) to head (469a703).
⚠️ Report is 343 commits behind head on master.

Files with missing lines Patch % Lines
...forceSDKCore/Classes/Login/SFLoginViewController.m 57.14% 3 Missing ⚠️
...lesforceSDKCore/Classes/OAuth/SFOAuthCoordinator.m 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4024      +/-   ##
==========================================
+ Coverage   63.35%   65.21%   +1.86%     
==========================================
  Files         250      260      +10     
  Lines       21659    22533     +874     
==========================================
+ Hits        13723    14696     +973     
+ Misses       7936     7837      -99     
Components Coverage Δ
Analytics 70.78% <ø> (ø)
Common 69.75% <66.66%> (+0.35%) ⬆️
Core 57.08% <71.13%> (+3.29%) ⬆️
SmartStore 74.70% <100.00%> (+0.70%) ⬆️
MobileSync 87.41% <ø> (ø)
Files with missing lines Coverage Δ
...SalesforceSDKCore/Classes/OAuth/SFSDKAuthSession.m 91.42% <100.00%> (+1.10%) ⬆️
...SDKCore/Classes/UserAccount/SFUserAccountManager.m 44.17% <100.00%> (+4.92%) ⬆️
...lesforceSDKCore/Classes/OAuth/SFOAuthCoordinator.m 45.33% <75.00%> (+2.13%) ⬆️
...forceSDKCore/Classes/Login/SFLoginViewController.m 71.25% <57.14%> (+58.43%) ⬆️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

TestsPassedSkippedFailed ❌️
AuthFlowTester UI Test Results all1 ran1 ❌
TestResult
AuthFlowTester UI Test Results all
AuthFlowTesterUITests.xctest
LegacyLoginTests.testCAOpaque_DefaultScopes_WebServerFlow()❌ failure

@brandonpage brandonpage merged commit dfcf6b9 into forcedotcom:master Apr 24, 2026
22 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants