Skip to content

Cherry Pick Fix auth flow regressions. (#2876)#2877

Merged
brandonpage merged 1 commit intoforcedotcom:masterfrom
brandonpage:cherry-pick/auth-fixes
May 6, 2026
Merged

Cherry Pick Fix auth flow regressions. (#2876)#2877
brandonpage merged 1 commit intoforcedotcom:masterfrom
brandonpage:cherry-pick/auth-fixes

Conversation

@brandonpage
Copy link
Copy Markdown
Contributor

No description provided.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 5, 2026

1 Error
🚫 Please re-submit this PR to the dev branch, we may have already fixed your issue.

Generated by 🚫 Danger

@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 64.93%. Comparing base (b8308bd) to head (be2bac9).
⚠️ Report is 164 commits behind head on master.

Files with missing lines Patch % Lines
...src/com/salesforce/androidsdk/ui/LoginViewModel.kt 66.66% 0 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2877      +/-   ##
============================================
+ Coverage     55.33%   64.93%   +9.59%     
- Complexity     2443     2979     +536     
============================================
  Files           211      222      +11     
  Lines         17223    17478     +255     
  Branches       2403     2495      +92     
============================================
+ Hits           9531    11350    +1819     
+ Misses         6649     4914    -1735     
- Partials       1043     1214     +171     
Components Coverage Δ
Analytics 47.92% <ø> (ø)
SalesforceSDK 59.84% <82.30%> (+16.03%) ⬆️
Hybrid 59.05% <100.00%> (+1.08%) ⬆️
SmartStore 78.20% <ø> (ø)
MobileSync 81.68% <ø> (+6.50%) ⬆️
React 52.36% <ø> (+5.41%) ⬆️
Files with missing lines Coverage Δ
.../src/com/salesforce/androidsdk/ui/LoginActivity.kt 43.76% <ø> (+19.75%) ⬆️
...src/com/salesforce/androidsdk/ui/LoginViewModel.kt 87.60% <66.66%> (+27.20%) ⬆️

... and 104 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@JohnsonEricAtSalesforce JohnsonEricAtSalesforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@brandonpage brandonpage merged commit d8f3d8c into forcedotcom:master May 6, 2026
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants