Skip to content

Use current Foobara version in generated gemspec #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azimux merged 4 commits into from
Sep 23, 2026
Merged

Use current Foobara version in generated gemspec #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49ff3c4
Use current Foobara version in generated gemspec
zhephyn Sep 21, 2026
87a5506
refactor to move Foobara version lookup into GemspecGenerator
zhephyn Sep 21, 2026
f7af47b
merge main into enhancement/default-foobara-minimum-to-the-current-ve…
zhephyn Sep 23, 2026
4e71b75
Fix Rubocop issue
zhephyn Sep 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions spec/generate_empty_ruby_project_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,15 @@
expect(result["spec/spec_helper.rb"]).to include('require_relative "../boot/finish"')
end

it "uses the current foobara version as the minimum dependency" do
expect(outcome).to be_success

current_version = Gem.loaded_specs["foobara"].version.to_s
gemspec_path = result.keys.find { |path| path.end_with?(".gemspec") }

expect(result.fetch(gemspec_path)).to include(">= #{current_version}")
end

@azimux azimux Sep 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a bit skeptical about this test but mostly harmless I think so I'll merge it

@zhephyn zhephyn Sep 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could submit another PR to improve it. Though I'm curious what the improvement could be. maybe an idea i have is that the test is currently testing for just this part ">= #{current_foobara_version}". Maybe it could be improved to test this entire line ">= #{current_foobara_version}", "<2.0.0". Though i wonder if that would make the test a bit more rigid because what it we go past the 2.0.0 version in the future?


it "uses the generated project library path in the README" do
expect(outcome).to be_success

Expand Down
4 changes: 4 additions & 0 deletions src/generators/gemspec_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ def template_path
def target_path
"#{kebab_case_full_project_name}.gemspec"
end

def current_foobara_version
Gem.loaded_specs["foobara"].version
end
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion templates/gemspec.gemspec.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
"CHANGELOG.md"
]

spec.add_dependency "foobara", ">= 0.0.136", "< 2.0.0"
spec.add_dependency "foobara", ">= <%= current_foobara_version %>", "< 2.0.0"

spec.require_paths = ["lib"]
spec.metadata["rubygems_mfa_required"] = "true"
Expand Down
Loading